atom-keymap icon indicating copy to clipboard operation
atom-keymap copied to clipboard

Add aborted bindings to the did-match-binding event

Open lee-dohm opened this issue 6 years ago • 0 comments

Description of the Change

Why keybindings act the way that they do is sometimes a mystery to Atom users. One of the ways that isn't surfaced well is when one keybinding is aborted and another is executed in its place. This change adds a list of aborted bindings to the onDidMatchBinding event so they can be surfaced in the keybinding-resolver package.

Alternate Designs

None considered.

Benefits

People will be able to debug their keybindings better.

Possible Drawbacks

The difference between the abort! command name and the e.abortKeyBinding function is also not well understood. This change may confuse some Atom users by making that difference more visible.

Applicable Issues

N/A

lee-dohm avatar Oct 11 '17 21:10 lee-dohm