minimap-git-diff icon indicating copy to clipboard operation
minimap-git-diff copied to clipboard

Full line coloring is gone

Open lczech opened this issue 3 years ago • 7 comments

Hi there, and thanks for this amazing plugin!

Since a few days, I noticed that the minimap does not show lines with git diffs fully colorized, but just as a very small vertical strip on the left:

image

This makes it really hard to see where diffs are in the minimap. Is there a way to get the old behavior back, where the whole line was marked in orange or green in the minimap?

Thanks!

lczech avatar May 12 '21 19:05 lczech

Can you share your versions for Atom, minimap, minimap-git-diff, and OS?

UziTech avatar May 12 '21 19:05 UziTech

Ah sorry, yes sure:

Ubuntu 20.04.2 LTS Atom 1.57.0 minimap 4.39.14 minimap-git-diff 4.3.6

lczech avatar May 12 '21 20:05 lczech

There seems to be a lot of issues with ubuntu 20.04 and minimap. @aminya could this be a canvas issue?

UziTech avatar May 12 '21 20:05 UziTech

Hm, it was working fine a few days ago. Not sure what changed since.

lczech avatar May 12 '21 20:05 lczech

most likely updating Atom is what broke it. https://github.com/atom-minimap/minimap/issues/795

Atom v1.56 updated electron to v9 which broke some things on linux.

UziTech avatar May 14 '21 16:05 UziTech

Okay, thank you for the info! I guess we'll just wait for atom/minimap to fix this :-) Or is there anything else that we can do here? If not, feel free to close this issue!

lczech avatar May 27 '21 07:05 lczech

There is almost certainly not anything this plugin can do. Minimap handles all of the rendering so it might require a change in minimap or Atom. I'm guessing it is happening because the current version of Atom has a bug in canvas rendering on Ubuntu.

UziTech avatar May 28 '21 20:05 UziTech