arts icon indicating copy to clipboard operation
arts copied to clipboard

Add pyarts metmm

Open obobryshev opened this issue 3 years ago • 3 comments

Hi Oliver,

I followed the "How to contribute guidelines". This is a fully working py-metmm setup using the pyarts. All sensors setups run without problems.

Several issues that I know of:

  1. I had to switch on robust=1 in ybatchCalc, because I got the following run-time error for Garand atmospheres index: 16,17 and 21
Run-time error in method: atmfields_checkedCalc
There are bad partition functions in your setup.
Minimum temperature for defined partition functions is: 150 K.
Maximum temperature for defined partition functions is: 300 K
There is a t_field entry of 314.81 K.
  1. Current origin/master branch results in the deltas of -30 to 60K compared with "ybatchREFERENCE.xml". Also, the TestMetMM in controlfiles/instruments/metmm fails with similarly big differences.
  • Also "O2-TRE05" full model gives -30 to 60K difference to the "ybatchREFERENCE.xml".
  • Check of "amsub" setup with reference only works for branches remotes/origin/v2.4.x and remotes/origin/before-newlinerecord.
  1. One note to the "How to commit" documentation. I didn't understand the section Update your working copy, and what the upstream and rebase actually do, e.g. in this code git pull --rebase upstream master.

  2. I have a separate github repository for py-metmm setup. I created it if I need to imporove the metmm code a bit more. https://github.com/obobryshev/py_metmm

  3. MetMM setup relies on the extract of HITRAN2012 with the changed line parameters for WV line at 183.31 GHz: controlfiles/instruments/metmm/abs_lines_metmm.xml.gz Both metmm versions rely on this file. Is it ok to rely on this file for both versions for now? In the end I plan to read the HITRAN catalogue and change this one line parameters on-the-fly using the function abs_linesReplaceWithLines. This is an open todo.

Kind regards, Alex

obobryshev avatar Sep 14 '21 15:09 obobryshev