eixport icon indicating copy to clipboard operation
eixport copied to clipboard

Wrong Molar Masses

Open C130PA5 opened this issue 1 year ago • 3 comments

I don't know if this repository is still used and updated. However, I noticed that molar masses in the chem_edgar.R file are wrong.

C130PA5 avatar Jan 11 '24 14:01 C130PA5

Hi @C130PA5 , thanks for catching up that error. Maybe you can post the molar mass here, or you can provide a pull request and I can add you as contributor

ibarraespinosa avatar Jan 13 '24 17:01 ibarraespinosa

For SO2, the total molar mass is 64 however in the code it is 64+16*2. This occurs in the entire file. Example:
E_SO2 <- bp$so2 / (64 + 16 * 2) # emis_opt$eradm[2] E_NO <- bp$nox * 0.9 / (14 + 16) # emis_opt$eradm[3] E_CO <- bp$co / (12 + 18) # emis_opt$eradm[4]

C130PA5 avatar Jan 23 '24 14:01 C130PA5

I see

On Tue, Jan 23, 2024, 7:29 AM Charbel Abdallah @.***> wrote:

For SO2, the total molar mass is 64 however in the code it is 64+16*2. This occurs in the entire file. Example: E_SO2 <- bp$so2 / (64 + 16 * 2) # emis_opt$eradm[2] E_NO <- bp$nox * 0.9 / (14 + 16) # emis_opt$eradm[3] E_CO <- bp$co / (12 + 18) # emis_opt$eradm[4]

— Reply to this email directly, view it on GitHub https://github.com/atmoschem/eixport/issues/78#issuecomment-1906173045, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGRM74EOJGVDTFWBZRER5QTYP7CMDAVCNFSM6AAAAABBWRXO7CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBWGE3TGMBUGU . You are receiving this because you were assigned.Message ID: @.***>

ibarraespinosa avatar Jan 23 '24 14:01 ibarraespinosa