atlos icon indicating copy to clipboard operation
atlos copied to clipboard
verified publisher icon atlosdotorg

Add Support for Custom Filters

Open JettChenT opened this issue 2 years ago • 5 comments

#551

JettChenT avatar Feb 13 '24 17:02 JettChenT

Deploy Preview for atlos-docs canceled.

Name Link
Latest commit fc30c87c97e75e023ecc46aecc9051c527ed2b6b
Latest deploy log https://app.netlify.com/sites/atlos-docs/deploys/65f056437c11800008e8334c

netlify[bot] avatar Feb 13 '24 17:02 netlify[bot]

Thanks for the review!

  • For the different naming of [Unset] and None, it seems like it is set on purpose for the tag attribute at: https://github.com/atlosdotorg/atlos/blob/9f2df58f541d29494cf49d5319f9f96ad0fa6870/platform/assets/js/app.js#L267 . Should I change "None" to "Unset" here?
  • Applied the other suggestions in the main comment

JettChenT avatar Feb 15 '24 10:02 JettChenT

Ah, I see, the [Unset]/none was not something you introduced. Can we update the way we initialize TomSelect so that it displays the [Unset] tag as None (not set)? If not, then perhaps we remove this special case and just display the value as [Unset] in both the dropdown and in the tag list. Seeing None in the dropdown and [Unset] in the tag list was a bad product decision.

image

You can also ofc keep that out of scope for this PR and make no change, as long as filtering to unset values functions properly.

milesmcc avatar Feb 15 '24 15:02 milesmcc

Thanks for the review! Addressed the issues in the latest commit.

P.S. love the updated date entry UI!

JettChenT avatar Mar 12 '24 13:03 JettChenT

Awesome! Learned a lot working on this PR

JettChenT avatar Mar 17 '24 06:03 JettChenT