react-beautiful-dnd Remove pure: true, for react-redux 8 compatibility

Remove pure: true, for react-redux 8 compatibility

Open circlingthesun opened this issue 3 years ago • 7 comments

When using react-redux 8.0.0-alpha.1 with rbd, you get the following error:

'The 'pure' option has been removed. 'connect' is now always a "pure/memoized" component'

Given that pure: true was the default before, removing this option ensures that rbd works with react-redux 7 & 8.

Nov 17 '21 13:11 circlingthesun

Hooray! All contributors have signed the CLA.

Nov 17 '21 13:11 atlassian-cla-bot[bot]

Now that react-redux v8 is out this should be accepted

Apr 20 '22 19:04 davbrito

This is needed for compatibility with react-redux v8.

Apr 26 '22 13:04 tlouth19

Still not accepted? 😔

Mar 01 '23 01:03 guoguoqiqi

Any other work around to this issue?

Mar 30 '23 08:03 SandeshR98

Would be nice to get this fixed to avoid the warning in the console.

Jun 28 '23 05:06 mikkopori

It would be great to get this in!

I'm not sure if it was due to yarn/node differences, but I had to make some small changed to the namedExports to get build working.

https://github.com/atlassian/react-beautiful-dnd/commit/6b795562ac993a4b20a62027124a336c0258edab

Nov 21 '23 20:11 ericbdev