github-for-jira Feature request: Pull request approved

Hi !

Just as an automation already exists for when a pull-request is declined, it would be nice to trigger action when a pull-request is approved.

Does this feature is already part of your roadmap ?

Thanks !

Jun 07 '21 17:06 felixveysseyre

Hi @felixveysseyre. The 3 pull request automations currently include what's seen in the below screenshot:

Does merging the PR support the automation you are after? If not, I can try and point you to the right team to make a feature request. We look after the GitHub for Jira integration whereas you'd need to get in contact with the automations team.

Jul 14 '21 06:07 rachellerathbone

Haven't heard back in a month, I'm going to close this one. Please reopen it if we haven't answered your question. Cheers.

Aug 17 '21 08:08 mboudreau

@mboudreau I'm sorry, I missed this notification and apparently I do not have sufficient permission to reopen this issue.

@rachellerathbone These three events do not fit my needs. I would like to trigger and action when the pull-request has been approved, not merged To give you some more context, we do have an automated process which deploys automatically the code of the pull-request. Once the the pull-request has been approved, we manually change (that's the behavior we would like to automate) the status of the related Jira ticket in order to let our QA engineers know about it. From here, they are able to test the related changes and merge (or not) the original pull-request

Let me know if it's sill unclear 🙇‍♂️

Aug 17 '21 08:08 felixveysseyre

Alright, reopening the issue. Sound like a good idea for a new event. We'll have to bring it up with the team responsible for jira automation.

Aug 17 '21 11:08 mboudreau

+1

We're looking at integrating this same workflow mentioned by @felixveysseyre and glad we found this!

Nov 23 '21 10:11 iamstej

I'd appreciate this, as well.

It would be good to include information, for github integrations at least, about all outstanding reviews in all statuses, e.g. requested, approved, etc. If that doesn't make sense, then just having the number of approvals would be useful.

Dec 06 '21 14:12 rileywhite

+1 would also appreciate this.

Jan 04 '22 17:01 edelegormley

+1; some folks don't have access to GitHub and all they need to know is whether a PR has been approved yet (vs. still waiting for review). So being able to distinguish this from the Jira issue would be very useful.

Jan 25 '22 20:01 simonyun

+1; we need to promote approved PRs to further development stages

Feb 11 '22 08:02 drdaemos

Surely this can't be that difficult. The info from GitHub is already synced to Jira.

https://github.com/atlassian/github-for-jira/blob/5d0e37c544031319ebf8afdb8c2e23055c461677/src/transforms/pull-request.ts#L118

The info is there to use and is already shown alongside the pull request in the development info window

(ignore the red boxes - just best screenshot I could find)

The development panel already has an implementation for review which Crucible uses: https://support.atlassian.com/jira-software-cloud/docs/view-development-information-for-an-issue/#See-the-status-of-reviews

Why is the review information shown for pull requests not surfaced in the same way?

It also means the JQL development[reviews].all doesn't work as expected