github-for-jira icon indicating copy to clipboard operation
github-for-jira copied to clipboard

Published 20 hours ago • verified publisher icon atlassian

Feature request: Create JIRA issue from PR Review

Open sfc-gh-sgiesecke opened this issue 4 years ago • 9 comments
trafficstars

Just like it's possible to create a GitHub issue from a PR Review Discussion Thread, it should be possible to create a JIRA issue prefilled with appropriate information, including a link to the originating PR and discussion item.

sfc-gh-sgiesecke avatar May 20 '21 14:05 sfc-gh-sgiesecke

Hey @sfc-gh-sgiesecke,

can you elaborate on that idea a bit? How is it currently possible to create a GitHub issue from a PR review discussion (I didn't find that option). So, if I understand correctly, you would want a button in the GitHub UI that gives you the option to create a Jira ticket?

thombergs avatar May 21 '21 00:05 thombergs

You can even see it on this discussion as well. It's the same for a PR review discussion. I am not sure what information goes into the new issue. For JIRA, this must probably be configured with more details, as JIRA has many more fields that might need to be prefilled than GitHub issues.

Screenshot 2021-05-21 at 09 36 27 Screenshot 2021-05-21 at 09 37 01

sfc-gh-sgiesecke avatar May 21 '21 07:05 sfc-gh-sgiesecke

Hey @sfc-gh-sgiesecke. Can I get some more clarification around what you're hoping for here? Why specifically from a PR review? I ask this because when our team reviews one another's PRs, we're usually assessing the code that has been written and trying to close out an issue that is already attached to that work. It's hard for me to imagine a scenario where a reviewer would leave a review and then, at some point in the discussion thread, decide a new issue should be created.

rachellerathbone avatar Oct 19 '22 03:10 rachellerathbone

Can I get some more clarification around what you're hoping for here?

Well, to start with I expect the same functionality that exists for creating GitHub issues to be available to create Jira issues.

I ask this because when our team reviews one another's PRs, we're usually assessing the code that has been written and trying to close out an issue that is already attached to that work. It's hard for me to imagine a scenario where a reviewer would leave a review and then, at some point in the discussion thread, decide a new issue should be created.

There are surely different workflows. I am not sure I understand what you're saying here. In my current and also all past projects, it was very typically that there are discussion/action items encountered that are considered worthwhile addressing but shouldn't block the PR at hand. Either a reviewer or an author might decide to move this into an issue in the issue tracker.

As mentioned above, this functionality/integration exists for GitHub issues, and it would be good to be at par at that to support the same workflows.

sfc-gh-sgiesecke avatar Oct 19 '22 13:10 sfc-gh-sgiesecke

I second this. When working with a "non-perfect" codebase, it happens frequently, that a reviewer sees something that needs improvement, that doesn't have anything to do directly with the PR at hand and like @sfc-gh-sgiesecke said above, shouldn't block the PR. Github saw this and offered this option to create issues from comments. There also exists https://github.com/atlassian/github-for-jira/issues/723, which asks for something similar and includes a proposal of what that might look like.

christian-steinmeyer avatar Dec 06 '22 08:12 christian-steinmeyer

Came here when looking for a solution to this exact feature. It's available in Bitbucket and would love it for GitHub.

DanFCo avatar Mar 16 '23 20:03 DanFCo