github-for-jira icon indicating copy to clipboard operation
github-for-jira copied to clipboard

Duplicate Jira API requests to check for ticket existence

Open jnraine opened this issue 4 years ago • 1 comments

When editing an issue that mentioned a ticket (WS-1), I saw three requests to the Jira API to check if that one ticket existed.

Here are the logs:

2019-08-20T16:38:09.850897+00:00 app[web.1]: 16:38:09.850Z DEBUG probot: Webhook received
2019-08-20T16:38:09.850912+00:00 app[web.1]: event: {
2019-08-20T16:38:09.850915+00:00 app[web.1]: "event": "issues.edited",
2019-08-20T16:38:09.850918+00:00 app[web.1]: "id": "e4d2dbf0-c368-11e9-99f3-06963d9a15af",
2019-08-20T16:38:09.850920+00:00 app[web.1]: "installation": 1538583,
2019-08-20T16:38:09.850922+00:00 app[web.1]: "repository": "jnraine/top-scholar"
2019-08-20T16:38:09.850924+00:00 app[web.1]: }
2019-08-20T16:38:10.004842+00:00 app[web.1]: 16:38:10.004Z DEBUG probot: Jira request: GET /rest/api/latest/issue/WS-2?fields=summary - 404  (id=e4d2dbf0-c368-11e9-99f3-06963d9a15af, installation=1538583)
2019-08-20T16:38:10.004847+00:00 app[web.1]: params: {
2019-08-20T16:38:10.004850+00:00 app[web.1]: "fields": "summary",
2019-08-20T16:38:10.004852+00:00 app[web.1]: "issue_id": "WS-2",
2019-08-20T16:38:10.004854+00:00 app[web.1]: "baseUrl": "https://github-integration.atlassian.net"
2019-08-20T16:38:10.004856+00:00 app[web.1]: }
2019-08-20T16:38:10.009833+00:00 app[web.1]: 16:38:10.009Z DEBUG probot: Jira request: GET /rest/api/latest/issue/WS-2?fields=summary - 404  (id=e4d2dbf0-c368-11e9-99f3-06963d9a15af, installation=1538583)
2019-08-20T16:38:10.009837+00:00 app[web.1]: params: {
2019-08-20T16:38:10.009840+00:00 app[web.1]: "fields": "summary",
2019-08-20T16:38:10.009842+00:00 app[web.1]: "issue_id": "WS-2",
2019-08-20T16:38:10.009845+00:00 app[web.1]: "baseUrl": "https://github-integration.atlassian.net"
2019-08-20T16:38:10.009846+00:00 app[web.1]: }
2019-08-20T16:38:10.011130+00:00 app[web.1]: 16:38:10.010Z DEBUG probot: Jira request: GET /rest/api/latest/issue/WS-2?fields=summary - 404  (id=e4d2dbf0-c368-11e9-99f3-06963d9a15af, installation=1538583)
2019-08-20T16:38:10.011133+00:00 app[web.1]: params: {
2019-08-20T16:38:10.011135+00:00 app[web.1]: "fields": "summary",
2019-08-20T16:38:10.011137+00:00 app[web.1]: "issue_id": "WS-2",
2019-08-20T16:38:10.011139+00:00 app[web.1]: "baseUrl": "https://github-integration.atlassian.net"
2019-08-20T16:38:10.011141+00:00 app[web.1]: }

Are we making unnecessary API requests?

jnraine avatar Aug 20 '19 16:08 jnraine

Triaged 😄

rachellerathbone avatar May 17 '21 23:05 rachellerathbone

We don't believe this is an issue anymore so closing. Please feel free to reopen if you need more help.

rachellerathbone avatar Oct 18 '22 23:10 rachellerathbone