github-for-jira icon indicating copy to clipboard operation
github-for-jira copied to clipboard

Issue references in PRs not being linked

Open mbatchelor opened this issue 2 years ago • 17 comments

We have issue references in PRs that used to show up linked and now don't. Formats that used to work (and are now not showing links:

feat: [CDS-31304]: Fixes for migration fix: [PL-19562]: fix error when not able to connect to Git provider [CI-3602]: unclear error - namespace not found

This is not limited to our project only, but it shows up in open source projects as well: https://github.com/pentaho/pentaho-kettle/pulls PDI-18996 resolution [SP-6110][BAD-1920] Optional automatic updates of Hadoop*-site.xml

https://github.com/chocolatey/ChocolateyGUI/pulls [WIP] (GH-376) Added new chocolatey packages

mbatchelor avatar Mar 17 '22 12:03 mbatchelor

01 - Source Tree 02 - PR List

See examples here

mbatchelor avatar Mar 21 '22 12:03 mbatchelor

I don't believe it has anything to do with permissions either. For example, https://github.com/apache/kafka/pulls shows that KAFKA-6718 (and all the others listed) aren't showing linking. However, https://issues.apache.org/jira/browse/KAFKA-6718 is completely accessible. And if you go to the source tree (https://github.com/apache/kafka), you will see issue links working (so the Apache org has github-for-jira correctly tied to their Jira instance). See images below: 03 - Kafka PRs with no links 04 - Kafka Source Tree with links

mbatchelor avatar Mar 21 '22 12:03 mbatchelor

Experiencing similar issues where links to Jira are not being created in PR descriptions as per these instructions

travipross avatar Mar 30 '22 19:03 travipross

@mbatchelor Happy to look into this. is it only for PRs? is the PR title with the ticket number that's not being linked or the PR description?

mboudreau avatar Mar 31 '22 00:03 mboudreau

I'm experiencing the same issue in a private repository. From what we've seen, having the Jira issue code in the branch will appropriately link to the Jira issue and will transition it as it moves through code review. However, noted the issue in the PR description or comments, as well as individual commits, do not work. Jira issues are not linked in those situations.

FWIW, the "commits" tab in the Jira issue does show the appropriate commits, but there is nothing updated on Github, and if the PR status is changed, Jira status is not updated like it is when the issue is in the branch name.

BradLucky avatar Apr 02 '22 03:04 BradLucky

Hey @mboudreau , I tried re-doing the backfill on Friday before I answered you just to see if things would improve. Alas, they didn't.

  • All our commits have a JIRA case. Even if you just go here ( https://github.com/harness/harness-core ) you can see that some have issue links, and some don't. All cases listed are valid cases. So for example PL-21808 shows the issue link, but CDS-35566 doesn't. This is not even looking at the open PRs.
  • On the Open PRs, NONE of them have issue links (https://github.com/harness/harness-core/pulls)
  • On the commits tab - some are working, some are not. (https://github.com/harness/harness-core/commits/develop)

Once again - I re-did the "backfill" on Friday, just to see if things changed, but they didn't.

Also you can see the PR issue in other open source projects as I mention above with Kafka. Simply go to https://github.com/apache/kafka/pulls and you'll see that none of them have issue links. Yet, if you go to their trunk view, they're clearly integrated with Jira: https://github.com/apache/kafka

Note - we're using Jira Cloud.

mbatchelor avatar Apr 04 '22 13:04 mbatchelor

Hey @mboudreau - any update on this ?

mbatchelor avatar Apr 15 '22 10:04 mbatchelor

@mbatchelor I've been working on figuring out the issue for this and well, there's a few issues are play here that I'm trying to address. Not sure when the fix will be added as more testing is needed, but we've currently got more pressing matters to attend to as I'm sure you're aware.

We're very sorry for the wait as this issue should have been caught much earlier. Good news is, we're making the sync much more robust and including builds and deployments as part of the sync as well so all data is captured.

I'll be updating this once we have a fix in place.

mboudreau avatar Apr 15 '22 11:04 mboudreau

Any updates on this? We're seeing this intermittently as well and it seems to especially be happening with a very large repo we have.

mtoigo avatar Apr 26 '22 13:04 mtoigo

@mboudreau - any updates on this ?

mbatchelor avatar May 23 '22 09:05 mbatchelor

Hey @mboudreau - it's been about two months without an update. Can you please provide an update? Thanks!

mbatchelor avatar Jun 20 '22 13:06 mbatchelor

Please provide an update to this.

wes8ty avatar Jul 12 '22 16:07 wes8ty

@mbatchelor @mtoigo @wes8ty I'm so sorry, I completely missed the notification for this in the massive amounts of spam in my inbox :|

The crux of the issue is currently outside of our hands as it's based on a problem with our Jira API and how we validate issue keys. This has been brought up to that team but hasn't been prioritized. I still have some lingering issues I'm working through and I'll add that as the next item on said list as it's not getting any momentum.

mboudreau avatar Aug 25 '22 07:08 mboudreau

Any update on this pls?

wes8ty avatar Oct 11 '22 15:10 wes8ty

Hey @wes8ty are you also seeing an issue with this?

rachellerathbone avatar Oct 19 '22 03:10 rachellerathbone

Yes, we are. No linkage is occurring. Last update stated

The crux of the issue is currently outside of our hands as it's based on a problem with our Jira API and how we validate issue keys. This has been brought up to that team but hasn't been prioritized. I still have some lingering issues I'm working through and I'll add that as the next item on said list as it's not getting any momentum.

As a result, I was wondering if this was fixed because we are not seeing it on our end.

wes8ty avatar Oct 20 '22 13:10 wes8ty

@rachellerathbone any update here?

ograff avatar Sep 06 '23 17:09 ograff