gajira-login icon indicating copy to clipboard operation
gajira-login copied to clipboard

fix: display name

Open gokaygurcan opened this issue 3 years ago • 4 comments

Hi,

Atlassian API returns something like this:

{
    "self": "",
    "accountId": "",
    "emailAddress": "",
    "avatarUrls": {
        "48x48": "",
        "24x24": "",
        "16x16": "",
        "32x32": ""
    },
    "displayName": "",
    "active": true,
    "timeZone": "",
    "locale": "",
    "groups": {
        "size": 0,
        "items": []
    },
    "applicationRoles": {
        "size": 0,
        "items": []
    },
    "expand": "groups,applicationRoles"
}

That's why, we keep seeing a weird message in GitHub Actions logs like:

Logged in as: undefined

This change is to fix that problem, and to display correct name value.

Best, G.

gokaygurcan avatar Mar 22 '21 16:03 gokaygurcan

hello?

gokaygurcan avatar Apr 12 '21 13:04 gokaygurcan

Hi @thombergs,

(At the time i was typing this message, you were the last committer to github-for-jira repository. That's the only reason why I'm pinging you and not someone else)

Can you please confirm that this repository is dead? There's no activity since 2019 and there're open PRs to fix some broken things and no one cares about those. If the repo is dead, I think we deserve to know it so that we can move on and do it in our way instead of depending on this official solution. Which is not your priority anyway from the looks of it.

I hope this makes sense.

Best, G.

gokaygurcan avatar Sep 25 '21 19:09 gokaygurcan

Hey @gokaygurcan,

let's ask @drudzikatlassian , @rudzon , @swinton, since they are listed as contributors for this repository.

Funny that you tag me, though, because my team will be taking up some work with GitHub Actions for Jira (probably early 2022) and I didn't know about this repository. I'll bring it up with the team so that we may discuss taking ownership of this repo earlier to review PRs and stuff. I'll have a look through the repo next week!

thombergs avatar Sep 25 '21 20:09 thombergs

Thanks big time!

gokaygurcan avatar Sep 26 '21 09:09 gokaygurcan