docker-chromium-xvfb icon indicating copy to clipboard operation
docker-chromium-xvfb copied to clipboard

Use semantic versioning/tags on the image

Open JohannesRudolph opened this issue 8 years ago • 4 comments

Can you tag images with a version in addition to applying the latest tag? Makes it easier to consume these fantastic images :-)

See also: https://medium.com/@mccode/the-misunderstood-docker-tag-latest-af3babfd6375#.2rq93tci3 for how convoluted docker tags are...

JohannesRudolph avatar Sep 27 '16 15:09 JohannesRudolph

Sure! Do you have a suggestion for how you'd version them?

Most of the images that I've seen on Docker Hub tend to follow the underlying version of a framework or major software release. In this case, I'm already doing that with Python 2 vs Python 3 and I'd certainly be open to doing that with the JS images.

Any ideas are very much welcome!

mark-adams avatar Oct 18 '16 02:10 mark-adams

I wouldn't mind if you just bumped a minor (e.g. 1.x) on each revision that doesn't contain breaking changes). The problem with this (and many other docker images) is that it's not 100% reproducible, e.g. the -js version installs node 6.x

RUN curl -sL https://deb.nodesource.com/setup_6.x | bash -
RUN apt-get install -y nodejs && npm install -g npm@latest

So the version on Docker Hub depends on the time the image was built.

On the other hand, just monotonically increasing the version would be fine with me as well. It's just meant to ensure people can pull an immutable image version from docker hub by tag.

JohannesRudolph avatar Oct 18 '16 09:10 JohannesRudolph

Just found the image and it works great for JS tests. This versioning scheme would be great. Otherwise, to have reproducible builds we need to build the image on our own. What can we do to help you on this?

vkruoso avatar Mar 27 '17 14:03 vkruoso

I started some work on this over the past few days: https://hub.docker.com/r/markadams/chromium-xvfb-js/tags/

The JS image now contains tags for 6.x and 7.x versions of Node and the exact versions are pinned in the Dockerfiles. Next, I'll probably create some tags for the minor versions as well.

mark-adams avatar Apr 01 '17 03:04 mark-adams