nadel icon indicating copy to clipboard operation
nadel copied to clipboard

This adds the ability to track the total number of ids to be hydrated

Open bbakerman opened this issue 3 years ago • 2 comments

This adds the ability to track the total number of ids to be hydrated plus per call how many we are acting on

Please make sure you consider the following:

  • [n/a ] Add tests that use __typename in queries
  • [ n/a] Does this change work with all nadel transformations (rename, type rename, hydration, etc)? Add tests for this.
  • [ n/a] Is it worth using hints for this change in order to be able to enable a percentage rollout?
  • [n/a ] Do we need to add integration tests for this change in the graphql gateway?
  • [ n/a] Do we need a pollinator check for this?

bbakerman avatar Dec 26 '21 21:12 bbakerman

looks good imo, just the merge conflicts

temaEmelyan avatar Jan 10 '22 23:01 temaEmelyan

Hmmm I'm very iffy on this. I get that we need this info, however I'd much rather track this in some sort of context object per hydration/query execution (which I think we may need for multitenanted hydrations that Artyom is working on, see my comment on that PR), rather than mess with the return type just to return an object 20 times in the hierarchy.

As an aside, I really want to add something like Dagger or kotlin-inject and clean up the way we pass around arguments and clean up how some objects are scoped to reduce the number of function parameters…

gnawf avatar Jan 12 '22 22:01 gnawf