compiled
compiled copied to clipboard
atlassian-labs
feat: add title attribute to Compiled style tag
TBH, I am not sure if this is a valuable change considering these devlop issues . Also, we know that classes starting with _ are usually Compiled; hence, we can just look for it.
However, it may save some keystrokes when debugging :)
Dev mode
It seems that we are having multiple style tags when extraction is not enabled, only one is getting the title attribute
VS
Prod mode
We can easily discern what style is for Compiled.
🦋 Changeset detected
Latest commit: b2531bf3a2d6fcab7912a62e6bb016778534a8d7
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 2 packages
| Name | Type |
|---|---|
| @compiled/parcel-optimizer | Minor |
| @compiled/parcel-config | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
![changeset-bot[bot] avatar](https://avatars.githubusercontent.com/in/28616?v=4 "Published by a pub.dev verified publisher"){kind=small}
ooh good idea 👍 do you reckon it would be useful to also add this to the SSR styles that have the data-cmpld="true" attribute?
(perhaps we can use title="parcel-compiled" instead of title="compiled" to distinguish which plugin the styles are coming from?)
We already have some similar behaviour for the runtime, maybe we should match that? https://github.com/atlassian-labs/compiled/blob/44b13234d50889c1f610102ee2751c9839d2ae35/packages/react/src/runtime/style.tsx#L48
We already have some similar behaviour for the runtime, maybe we should match that?
https://github.com/atlassian-labs/compiled/blob/44b13234d50889c1f610102ee2751c9839d2ae35/packages/react/src/runtime/style.tsx#L48
hmm yeah maybe we could keep data-cmpld for the SSR stuff and have data-compiled-parcel for the @compiled/parcel-optimizer output? will let @pancaspe87 make the final call on the best name for this
(i'm reluctant to use data-cmpld for everything because of how data-cmpld is being used here https://github.com/atlassian-labs/compiled/blob/44b13234d50889c1f610102ee2751c9839d2ae35/packages/react/src/runtime/style-cache.tsx#L20 )
Yeahh, I did see data-cmpld and thought it was specific to runtime.
TBH, I am happy to reuse data-cmpld or apply the same title='compiled' to everything . Whatever works best for you @JakeLane @dddlr @liamqma