atlassian-python-api icon indicating copy to clipboard operation
atlassian-python-api copied to clipboard

Published 20 hours ago • verified publisher icon atlassian-api

rest_client.py error on line 481 when values or keys are integers

Open 2ps opened this issue 1 year ago • 5 comments

We should use %, .format, or f-strings instead for situations when keys or values are integers, since + does not automatically type-convert for us.

2ps avatar Sep 09 '23 18:09 2ps

I think that the user should provide the data with the correct types. There can be parameters which need to be integers.

Spacetown avatar Sep 09 '23 19:09 Spacetown

@Spacetown This is in exception handling, I don't see how the user can specify which values are in the response json, although I am happy to hear suggestions.

2ps avatar Sep 16 '23 03:09 2ps

https://github.com/atlassian-api/atlassian-python-api/pull/1244 addresses this issue.

2ps avatar Sep 16 '23 03:09 2ps

@Spacetown @gonchik could I please get your review on this at your convenience?

2ps avatar Sep 16 '23 03:09 2ps

Ok, for exception handling this can be done. Next time you should use a permalink instead of a line number without a link.

Spacetown avatar Sep 16 '23 21:09 Spacetown