camelot icon indicating copy to clipboard operation
camelot copied to clipboard

Added fileObj to read file object

Open deepankurtaneja opened this issue 6 years ago • 7 comments
trafficstars

In Camelot there is already present functionality for reading PDF file using file path, but in order to read PDF files through file object was not possible in Camelot directly. Hence added one more function to allow read file object and modified few dependent functions to achieve it. This functionality has been tested on our side, please test it and merge it.

deepankurtaneja avatar May 24 '19 13:05 deepankurtaneja

I'll review this today.

vinayak-mehta avatar May 26 '19 10:05 vinayak-mehta

Codecov Report

Merging #331 into master will decrease coverage by 3.15%. The diff coverage is 22.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #331      +/-   ##
==========================================
- Coverage    87.2%   84.04%   -3.16%     
==========================================
  Files          13       13              
  Lines        1501     1561      +60     
  Branches      348      363      +15     
==========================================
+ Hits         1309     1312       +3     
- Misses        134      185      +51     
- Partials       58       64       +6
Impacted Files Coverage Δ
camelot/handlers.py 58.01% <24.61%> (-32.23%) :arrow_down:
camelot/io.py 60% <9.09%> (-40%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a1b85d2...725ff28. Read the comment docs.

codecov-io avatar May 27 '19 06:05 codecov-io

@vinayak-mehta Actually I am trying to read a PDF file while I am uploading it through web application and there I was not able to use read_pdf() method for file object, hence I added the file object function so as to read the PDF while uploading it via web app.

deepankurtaneja avatar May 28 '19 05:05 deepankurtaneja

Sorry for the delay in replies, please give me some time to look into this.

vinayak-mehta avatar Jun 21 '19 21:06 vinayak-mehta

Him i'm also interested in this feature, the need to have a local file (or a downloaded local file) prevents me to deploy camelot in a docker container without a volume.

Any updates about this PR ? Can i help ?

GuillaumeKLECH avatar Sep 05 '19 14:09 GuillaumeKLECH

Hi I would also really appreciate this feature... is there any progress in this task? From what I can see there are already two merge requests on this feature...

yeus avatar Oct 05 '20 21:10 yeus

just realizing this is a somewhat old? repository?

@deepankurtaneja if you read this, get the pull request over here:

  • https://github.com/camelot-dev/camelot

yeus avatar Oct 05 '20 21:10 yeus