wait4x icon indicating copy to clipboard operation
wait4x copied to clipboard

Add dns feature

Open atkrad opened this issue 2 years ago • 2 comments

atkrad avatar May 16 '23 18:05 atkrad

Pull Request Test Coverage Report for Build 13483900151

Details

  • 352 of 639 (55.09%) changed or added relevant lines in 15 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 53.585%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/app/wait4x/cmd/root.go 0 1 0.0%
checker/dns/dns.go 8 12 66.67%
checker/dns/a/a.go 40 45 88.89%
checker/dns/mx/mx.go 41 46 89.13%
checker/dns/ns/ns.go 41 46 89.13%
checker/dns/txt/txt.go 41 46 89.13%
checker/dns/aaaa/aaaa.go 48 57 84.21%
checker/dns/cname/cname.go 49 58 84.48%
internal/app/wait4x/cmd/dns/dns.go 0 18 0.0%
internal/app/wait4x/cmd/dns/ns.go 14 40 35.0%
<!-- Total: 352 639
Totals Coverage Status
Change from base Build 13398963833: 0.6%
Covered Lines: 1136
Relevant Lines: 2120

💛 - Coveralls

coveralls avatar Jun 03 '23 10:06 coveralls

The PR is ready :wink:

mortymacs avatar Jun 03 '23 10:06 mortymacs

any plan to merge this feature?

honwen avatar Feb 06 '25 13:02 honwen

Hey @honwen, thanks for your message. The PR has some conflicts. @mortymacs plans to fix them over the weekend. Hopefully, I can merge it next week.

atkrad avatar Feb 06 '25 13:02 atkrad

Hey @honwen, thanks for your message. The PR has some conflicts. @mortymacs plans to fix them over the weekend. Hopefully, I can merge it next week.

Done.

mortymacs avatar Feb 06 '25 16:02 mortymacs

Hey @honwen, thanks for your message. The PR has some conflicts. @mortymacs plans to fix them over the weekend. Hopefully, I can merge it next week.

tks

honwen avatar Feb 17 '25 02:02 honwen