data icon indicating copy to clipboard operation
data copied to clipboard

Published 20 hours ago • verified publisher icon atk4

Add weak conditions/save support

Open mkrecek234 opened this issue 2 years ago • 2 comments

related initial issue #967

mkrecek234 avatar Aug 25 '22 18:08 mkrecek234

Usecases? What is "weak" and when? Sometimes traversing should be weak, sometimes not, we should probably start with all possible usecases and then find a well understandable solution.

mvorisek avatar Aug 25 '22 20:08 mvorisek

please make the CS/stan CI happy and unit testing to finish at least

this is good practice so we can focus on the real issues

mvorisek avatar Aug 27 '22 20:08 mvorisek

see https://github.com/atk4/data/blob/aacc24708166f39c4595f829105dbccc4467739c/tests/LookupSqlTest.php#L112 I belive a weak approach is bad - any condition (added by an user) will still break the (currently commented) hook code. Maybe a solution can be to backup the conditions after init is invoked and allow it to be used like in https://github.com/atk4/data/pull/1054 invokeCallbackWithoutUndeletedCondition.

mvorisek avatar Jan 07 '23 11:01 mvorisek

closing in favor of #1054

mvorisek avatar Aug 12 '23 13:08 mvorisek