Anton Timmermans

Results 39 comments of Anton Timmermans

It does work this way right now for the license manager: https://github.com/Yoast/License-Manager/blob/master/class-product.php#L72. And the strings are picked up by `makepot.php` in wordpress-seo so that is the way we have done...

Wrong: ```php $value = filter_input( INPUT_SERVER, 'any-value' ); ``` Correct: ```php $value = $_SERVER[ 'any-value' ]; ``` This probably also requires sanitisation, because that is normally covered by `filter_input` but...

Sounds good to me. One thing to consider: Do we actually neer different folders for components and composites. What is thr advantage we have got or will get fron this...

This should also be a bug in Gutenberg? I think they should never have such specific selectors for metaboxes which are in control of plugins.

For posterity: We can only solve this by looking at the locale and changing behaviour for it.

Maybe we should exclude any sentence that has less than 3 characters.

I've asked our translations community manager to look into this.

From looking into this earlier I think it comes down to having a representation of all parsed content in a giant object that is then passed to a function that...

Do we really need to have a sleep of 3 seconds to stop this race condition? Completely removing the sleep might break something. But if we put it at 1...

I have no objection to removing the sleep and I have never had any problems with quick runs, it's just that I forget the quick flag sometimes.