Atif Aziz

Results 295 comments of Atif Aziz

> I liked a lot this new implementation. @leandromoh Glad to hear. > How about receive a predicate (Func) to indicate a split? This allow user split by other criterious....

> Why dont write SplitAt in terms of Segment? It would almost work but it can't be used because `Segment` doesn't _always_ produce a sub-sequence. With `SplitAt`, if the source...

This is a good idea and something I've been wanting to do for some time. Is it something you would like to help with? Meanwhile, you don't have spell out...

This comment is just a note that while [the same was done for `Enumerable.Zip`](dotnet/corefx#26582) in the CoreFX repo, it [was later reverted](https://github.com/dotnet/corefx/pull/33709) due to [strong differences in opinions about the...

> Fixed in #639 Correction: this is being addressed in PR #598. It is _not fixed_ unless a PR is merged into the master branch and neither PR #598 nor...

This is just an idea but `Acquire` can be overloaded to return any type of collection, including a `LinkedList`: ```c# public static TCollection Acquire(this IEnumerable source, TCollection disposables) where TSource...

> A solution is to build hand crafted implementation for every methods and prohibit nested enumerable ;) Or hijack `MoreEnumerable` extension methods within the test project [as is done for...

Four things: - Boolean values hinder readability (which can be somewhat offset by naming arguments or, better yet, introducing an `enum`). - Why do you need three Boolean flags? Isn't...

> We add possibility for dynamic choice Why? Just for the sake of adding features and richness? Is there a compelling use case that can be demonstrated? Keep in mind,...

I haven't done a study of whether it would help or not but if you'd like to take a crack at this through a PR then I'd be happy to...