PyImpetus icon indicating copy to clipboard operation
PyImpetus copied to clipboard

Enhancement request: Build a Directed Acyclic Graph

Open ivan-marroquin opened this issue 2 years ago • 2 comments

Dear Atif Hassan,

Many thanks for making available this package!

I read with great interest your publication, and I noticed that Pylmpetus report a complete Markov Blanket (parents, children, spouses) in a single run! Other algorithms require at least two runs to get such Markov Blanket (https://cran.r-project.org/web/packages/MXM/vignettes/MMPC_tutorial.html).

I would like to submit the following enhancements that I believe can help to facilitate the interpretation of the Markov Blanket:

  • Be able to recognize from selected features which ones are either parents, children, or spouses
  • Have a functionality to build a Directed Acyclic Graph (as shown in this R package https://github.com/malcolmbarrett/ggdag)

In the Directed Acyclic Graph, the nodes corresponding to parents have a specific color, which in turn it is different to the color assigned to either children or spouses. The remaining of features not belonging to Markov Blanket their nodes are plotted without color.

Kind regards,

Ivan

ivan-marroquin avatar Apr 13 '22 13:04 ivan-marroquin

Hi Ivan!

I think these are great ideas! Due to the property of the Markov Blanket, we know that the final selected set of features comprise only of the parent, child and spouses of the target variable. Even though, I have provided a feature importance generation technique, it is not possible to understand which nodes are the parent, child and spouse. Hence, your suggestions will definitely add to the interpretability of this work.

atif-hassan avatar Apr 14 '22 05:04 atif-hassan

Hi Atif Hassan,

Many thanks for paying attention to my request! I am looking forward for the addition of this new functionalities.

Kind regards,

Ivan

ivan-marroquin avatar Apr 14 '22 19:04 ivan-marroquin