Joel Höner comments

Results 116 comments of


                                            Joel Höner

Add [in,out] hints to Doxygen parameter strings

We use `const` to annotate pure input parameters. The only thing that SAL would provide on top of this is the ability to distinguish pure output parameters from in/out parameters....

Make packages `internal` to separate public and internal APIs

~The list looks good, except for `reporter`, which should definitely be public: its interface is one of the primary customization points.~ (nvm, misread OP)

Amalgamated build should auto-define `ZYDIS_STATIC_BUILD`

I think we should adjust the amalgamation script to automatically define those: I think it's safe to assume that pretty much no one will want to use the amalgamated sources...

armv7 benchmarks

Happy to include ARM disassemblers as well! I'm not really familiar with the library landscape around 32-bit ARM, and Capstone is the only other one that comes to mind. In...

Request: guidance for adding tests

Personally I wouldn't be opposed to more test cases, though I'd definitely want to go with an approach where we sample a subset from the "full parameter space". Not sure...

Add custom colors for file locations

Wouldn't mind it, PRs welcome!