Mathieu Lecarme
Mathieu Lecarme
I don't trust in global install, that's true. Python application should use a requirements.txt or a setup.py for the most brave. In the README.md, nobody should ask for global install....
ok, the tests are hidden in the code, without documentation in the README.
It's in the protocol, it crashs when you push large stuff without it, why doesn't use it in this library? Your split with range is far less ugly than my...
`bufsize` was not correctly handled. Does all connection in the collection pool has the same buffer size?
The cowboy snapshot seems to be rotten : ``` compile: warnings being treated as errors src/cowboy_http_websocket.erl:593: crypto:sha/1 is deprecated and will be removed in in a future release; use crypto:hash/2...
coverage: 61.2%
coverage: 69.0%
any comments, @buixor ? the check list is ok? does it worth to continue?
ok, the features are here, i'd like a review @blotus , if some parts need more comments or more tests. I tried to mimic style from the docker module, is...
coverage: 77.9%