colorls icon indicating copy to clipboard operation
colorls copied to clipboard

Remove `rubygems_mfa_required` setting and disable RequireMFA cop

Open avdv opened this issue 2 years ago • 1 comments

Description

This setting was introduced automatically by the aforementioned rubocop cop, which makes it impossible to publish to rubygems automatically from a Github action with an API key, since one would always need the second factor.

  • Relevant Issues : (none)
  • Relevant PRs : (none)
  • Type of change :
    • [ ] New feature
    • [ ] Bug fix for existing feature
    • [ ] Code quality improvement
    • [ ] Addition or Improvement of tests
    • [ ] Addition or Improvement of documentation

avdv avatar Jun 07 '23 19:06 avdv

@avdv @athityakumar any update on when this PR could be merged

ayushpoddar avatar Jun 23 '23 14:06 ayushpoddar

@avdv @athityakumar any update on when this PR could be merged

I can't merge it. I just published colorls 1.5.0 manually, including the change of this PR. This should unblock the situation, I hope.

avdv avatar Jul 07 '24 15:07 avdv

I can't merge it. I just published colorls 1.5.0 manually, including the change of this PR. This should unblock the situation, I hope.

Well, it will not do much, actually. Since any other change on top of the current main branch will restore the MFA setting if this PR is not merged.

Since I cannot merge my own PR, if anyone would be kind enough to create a new one with these changes that would work! :cat:

avdv avatar Jul 08 '24 16:07 avdv

I can't merge it. I just published colorls 1.5.0 manually, including the change of this PR. This should unblock the situation, I hope.

Well, it will not do much, actually. Since any other change on top of the current main branch will restore the MFA setting if this PR is not merged.

Since I cannot merge my own PR, if anyone would be kind enough to create a new one with these changes that would work! 🐱

So, should I create a PR with the exact changes that you've made in this PR?

ayushpoddar avatar Jul 08 '24 18:07 ayushpoddar

So, should I create a PR with the exact changes that you've made in this PR?

Yes, that would be awesome.

avdv avatar Jul 09 '24 06:07 avdv

So, should I create a PR with the exact changes that you've made in this PR?

Yes, that would be awesome.

@avdv I have created the PR: https://github.com/athityakumar/colorls/pull/620

ayushpoddar avatar Jul 12 '24 02:07 ayushpoddar