athityakumar
fix: 🐛 add support for files with no extension
Description
Updated the way the key is computed to allow for files without an extension to get icons.
- Relevant Issues :
- Fixes #459
- Relates to #469
- Relevant PRs : (none)
- Type of change :
- [ ] New feature
- [x] Bug fix for existing feature
- [ ] Code quality improvement
- [ ] Addition or Improvement of tests
- [ ] Addition or Improvement of documentation
Codecov Report
Patch coverage: 100.00% and project coverage change: +1.03 :tada:
Comparison is base (
5e0b25a) 90.86% compared to head (fdcd93c) 91.89%.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@
## main #577 +/- ##
==========================================
+ Coverage 90.86% 91.89% +1.03%
==========================================
Files 8 8
Lines 580 617 +37
==========================================
+ Hits 527 567 +40
+ Misses 53 50 -3
| Impacted Files | Coverage Δ | |
|---|---|---|
| lib/colorls/core.rb | 92.80% <100.00%> (+2.00%) |
:arrow_up: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Thank you @olirwin!
The tests failed, can you fix them?
Fixed as much as I could understand (there were 2 failing tests, one due to linter warnings, the other to test coverage). I am not in a position to write tests for this change in code.
The other tests were just being auto cancelled.
Solved this: add support for files with no extension #577 and: Fixes Icons for files without extenstions #459 Relates to Icons for file with only one extension #469
tests:
bundle exec rubocop
bundle exec rspec
test/run
finished OK
Here you can see dot-files with icons and file without extension with icon, and also can be file only from dots:
how to assign it to me ? and make me permission to commit branch and PR ?
