org-clock-csv icon indicating copy to clipboard operation
org-clock-csv copied to clipboard

Instead of Calling cl-assert, Signal Error With a Message

Open sshaw opened this issue 5 years ago • 1 comments

Just got an error message exporting to a file:

cl--assertion-failed: Assertion failed: (file-exists-p file)

Had to (setq debug-on-error t) to figure out why: https://github.com/atheriel/org-clock-csv/blob/e2fbaa1ad1a1be40fceecde603a600b292b76acc/org-clock-csv.el#L214-L216

The irony of the associated comment is not lost on me 😄

sshaw avatar May 20 '19 21:05 sshaw

I believe the comment refers to the fact that an even more obscure-looking error will occur if one of the files does not exist. However, I take your point -- the user-visible message could definitely be improved here.

atheriel avatar May 22 '19 03:05 atheriel