ATC_MiThermometer icon indicating copy to clipboard operation
ATC_MiThermometer copied to clipboard

Time value overflow?

Open eblot opened this issue 3 years ago • 4 comments

app_config.h:7 CLOCK_SYS_CLOCK_HZ = 24000000 app.c:79: 5*60000*CLOCK_SYS_CLOCK_1MS

CLOCK_SYS_CLOCK_1S = CLOCK_SYS_CLOCK_HZ
CLOCK_SYS_CLOCK_1MS = CLOCK_SYS_CLOCK_1S / 1000
5*60000*CLOCK_SYS_CLOCK_1MS= 7.2e9

-> 5*60000*CLOCK_SYS_CLOCK_1MS > UINT32_MAX

eblot avatar Jan 17 '21 09:01 eblot

Hey.

Yes that is a known issue.

Please take a look at @pvvx firmware edition, it is way more advanced now :)

atc1441 avatar Jan 17 '21 10:01 atc1441

https://github.com/atc1441/ATC_MiThermometer/issues/145#issuecomment-751494015

pvvx avatar Jan 18 '21 02:01 pvvx

@atc1441 So is this project abandonded? Should we migrate to https://github.com/pvvx/ATC_MiThermometer?

giannoug avatar Jan 19 '21 23:01 giannoug

Right now it is abandonded yes, I would not like to simply copy all the work from @pvvx as he improved so much its more grateful to directly use his fork :)

atc1441 avatar Jan 19 '21 23:01 atc1441