atc-react icon indicating copy to clipboard operation
atc-react copied to clipboard

Published 20 hours ago • verified publisher icon atc-project

Issue344 RA schema extension

Open xofolowski opened this issue 4 years ago • 5 comments

As discussed in Slack channel and Issue 344, I thought it might be useful to have an extensible / customisable yml-schema for response activities. Basically, a new array "details" was introduced, that can contain arbitrary variables (including additional arrays). In RA_1000_testing.yml I am showing, how the result could look like.

Actually, it's not a huge change but grants much more flexibility. Backward compatibility is granted.

As of now, appropriate jinja2-templates have only been created for MD.

xofolowski avatar Aug 05 '21 09:08 xofolowski

Hello @xofolowski! Thank you for your continuous contribution!

Backward compatibility is granted.

Could you please confirm that it will work with the current confluence jinja templates? As the workflow is now (in your PR) under details, it seems that it will be broken.

yugoslavskiy avatar Aug 23 '21 01:08 yugoslavskiy

Hi @yugoslavskiy, I added rudimental support for details-> workflow in the Ninja templates for both, RAs and RPs. Could you please verify? Cheers, XoF

xofolowski avatar Oct 02 '21 06:10 xofolowski

Hi @yugoslavskiy, confluence rendering of the workflow section should now be fine. Best XoF

xofolowski avatar Nov 20 '21 13:11 xofolowski

Hello @xofolowski ! Thank you very much for your contribution! Sorry for the delayed reply — having extremely busy time. Will check it it up shortly (:

yugoslavskiy avatar Dec 06 '21 00:12 yugoslavskiy

@xofolowski could you please restore .circleci/config.yml and .gitignore? For some reason, I cannot do that in web.

yugoslavskiy avatar Dec 06 '21 00:12 yugoslavskiy