GD3D11 icon indicating copy to clipboard operation
GD3D11 copied to clipboard

Support for G2-2.7-eng

Open kraugug opened this issue 6 years ago • 5 comments

I would like to add support for Gothic 2 v2.7 English binary.

kraugug avatar Aug 28 '19 23:08 kraugug

I don't see any commits by you, looks like you're not working with the master branch?

Or is this rather a discussion which should be held in an issue?

Supporting 2.7-eng will be hard if there are no debug-symbols in the executable. Does 2.7-eng come with debug symbols?

ataulien avatar Aug 29 '19 08:08 ataulien

Sorry my mistake. I'm quite new with Git and I really should read before what pull request actually means. Anyway I have it already working, but I wanted to somehow ask if I can push the changes. If yes, should I create a new branch?

And luckily 2.7-eng binary has debug symbols, but few changes was needed. I also added some stuff, if it is ok?

Screenshot

kraugug avatar Aug 29 '19 20:08 kraugug

I think your problem is that you are trying to merge into master_vs2015. You should instead checkout master, make a new branch, make your changes and then make pull request to merge into master, not master_vs2015.

Katharsas avatar Aug 29 '19 21:08 Katharsas

D'oh! That sounds logical. Thanks for the advice.

kraugug avatar Aug 29 '19 21:08 kraugug

Oh, that is awesome!

I think your problem is that you are trying to merge into master_vs2015.

@Katharsas He's actually trying to merge the master of ataulien/GD3D11 into master_vs2015, also of ataulien/GD3D11.

@kraugug I suggest you Fork this repository so you have "your own" repository you can work with. From there, you can send the pull request.

ataulien avatar Aug 30 '19 07:08 ataulien