xpadneo icon indicating copy to clipboard operation
xpadneo copied to clipboard

Build issue on kernel 6.17.0+

Open rkn45 opened this issue 2 months ago • 5 comments

Version of xpadneo

Clone of the master branch, dkms reports it as v0.9-144-g9b3b696

Severity / Impact

  • [x] I've read the docs and the bug reporting instructions
  • [ ] I've applied the latest firmware update to the controller
  • [ ] I've tried disabling or running without above mentioned software
  • [x] It does not work at all
  • [x] It used to work in a previous version
  • [ ] It mostly works but sometimes it doesn't
  • [ ] I found a work-around
  • [ ] I probably didn't figure it all out but it's too early to give up
  • [ ] I don't know how to ...
  • [ ] It's too complicated
  • [ ] Fantastic work but ...
  • [ ] I can code and I want to help

Describe the Bug

Build fails on mainline kernel 6.17.0+

Building module:
Cleaning build area...
make -j12 KERNELRELEASE=6.17.0+ -C /lib/modules/6.17.0+/build M=/var/lib/dkms/hid-xpadneo/v0.9-144-g9b3b696/build/src VERSION=v0.9-144-g9b3b696 modules...(bad exit status: 2)
Error! Bad return status for module build on kernel: 6.17.0+ (x86_64)
Consult /var/lib/dkms/hid-xpadneo/v0.9-144-g9b3b696/build/make.log for more information.

Steps to Reproduce

Just build the module, either with DKMS or by running install.sh

Expected Behavior

The module should build without errors.

Additional Context

Below is full make.log of the failed build:

DKMS make.log for hid-xpadneo-v0.9-144-g9b3b696 for kernel 6.17.0+ (x86_64)
Sat Oct 11 13:55:25 MSK 2025
make: Entering directory '/usr/src/linux-headers-6.17.0+'
make[1]: Entering directory '/var/lib/dkms/hid-xpadneo/v0.9-144-g9b3b696/build/src'
cp hid-xpadneo.c xpadneo.c
  CC [M]  xpadneo/core.o
  CC [M]  xpadneo/consumer.o
  CC [M]  xpadneo/keyboard.o
  CC [M]  xpadneo.o
xpadneo.c: In function 'xpadneo_probe':
xpadneo.c:1226:21: error: implicit declaration of function 'ida_simple_get' [-Werror=implicit-function-declaration]
 1226 |         xdata->id = ida_simple_get(&xpadneo_device_id_allocator, 0, 0, GFP_KERNEL);
      |                     ^~~~~~~~~~~~~~
xpadneo.c: In function 'xpadneo_release_device_id':
xpadneo.c:1331:17: error: implicit declaration of function 'ida_simple_remove' [-Werror=implicit-function-declaration]
 1331 |                 ida_simple_remove(&xpadneo_device_id_allocator, xdata->id);
      |                 ^~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
make[3]: *** [/usr/src/linux-headers-6.17.0+/scripts/Makefile.build:287: xpadneo.o] Error 1
make[2]: *** [/usr/src/linux-headers-6.17.0+/Makefile:2010: .] Error 2
make[1]: *** [/usr/src/linux-headers-6.17.0+/Makefile:248: __sub-make] Error 2
make[1]: Leaving directory '/var/lib/dkms/hid-xpadneo/v0.9-144-g9b3b696/build/src'
make: *** [Makefile:248: __sub-make] Error 2
make: Leaving directory '/usr/src/linux-headers-6.17.0+'

rkn45 avatar Oct 11 '25 10:10 rkn45

This appears to be working OK for me:

root@emilia:/usr/src/hid-xpadneo-v0.9-214-g8d20a23;
09:14:34 0$ dkms install hid-xpadneo/v0.9-214-g8d20a23 -k 6.17.3-athan
Sign command: /lib/modules/6.17.3-athan/build/scripts/sign-file
Signing key: /var/lib/dkms/mok.key
Public certificate (MOK): /var/lib/dkms/mok.pub
 
make -j16 KERNELRELEASE=6.17.3-athan -C '/lib/modules/6.17.3-athan/build' M='/var/lib/dkms/hid-xpadneo/v0.9-214-g8d20a23/build/src' VERSION='v0.9-214-g8d20a23' modules
 done.
Signing module /var/lib/dkms/hid-xpadneo/v0.9-214-g8d20a23/build/src/hid-xpadneo.ko
Installing /lib/modules/6.17.3-athan/updates/dkms/hid-xpadneo.ko.xz
Running the post_install script:
Not disabling ERTM, kernel version doesn't require it...
Installing modalias database...
Installing udev rules...
Reloading udev...
do_depmod 6.17.3-athan
 done.

But I am using a slightly different version of this project it seems. Your version is from:

commit 9b3b6968304d75faca00d1cead63f89e8895195f
Author: thiccaxe <[email protected]>
Date:   Mon Jul 17 15:46:10 2023 -0700
 
    Update TROUBLESHOOTING.md
    
    made explicit some additional troubleshooting steps when it comes to Xbox bluetooth failing.

but mine is later:

commit 8d20a23e38883f45c78f48c8574ac93945b4cb03 (HEAD -> master, origin/master, 
origin/HEAD)
Author: Kai Krakow <[email protected]>
Date:   Tue Dec 24 07:33:28 2024 +0100
 
    xpadneo, installer: Support installing documentation
    
    Signed-off-by: Kai Krakow <[email protected]>

There are also later commits than what I'm using. Perhaps try the latest from https://github.com/atar-axis/xpadneo/releases ?

Athanasius avatar Oct 16 '25 08:10 Athanasius

The "6.17+" they claim to be using appears to be based on 6.18. I also see the same two symbols fail when attempting to install on a 6.18-rc1 kernel.

kode54 avatar Oct 16 '25 11:10 kode54

We need to fix this when 6.18 settles.

kakra avatar Oct 16 '25 12:10 kakra

And 6.18 has now been released, any timeline on merging the PR ?

Athanasius avatar Dec 01 '25 11:12 Athanasius

v0.9 will not be supporting 6.17+ but v0.10 will. I'm going to tag that as stable "soonish". I'm going to rebase my kernel patches during the next days and will look at xpadneo while doing that.

kakra avatar Dec 01 '25 13:12 kakra