xpadneo icon indicating copy to clipboard operation
xpadneo copied to clipboard

kernel 6.12: error install

Open RaulKong898 opened this issue 1 year ago • 4 comments

raulkong898@fedora:~/xpadneo$ sudo ./install.sh

  • creating dkms.conf
  • adding hid-xpadneo-v0.9-175-g70ef8ee folder to /usr/src
  • installing module (using DKMS)

Sign command: /lib/modules/6.12.0-0.rc1.17.fc42.x86_64/build/scripts/sign-file Signing key: /var/lib/dkms/mok.key Public certificate (MOK): /var/lib/dkms/mok.pub Creating symlink /var/lib/dkms/hid-xpadneo/v0.9-175-g70ef8ee/source -> /usr/src/hid-xpadneo-v0.9-175-g70ef8ee

Cleaning build area... done. Building module(s)...(bad exit status: 2) Failed command: make -j12 KERNELRELEASE=6.12.0-0.rc1.17.fc42.x86_64 -C /lib/modules/6.12.0-0.rc1.17.fc42.x86_64/build M=/var/lib/dkms/hid-xpadneo/v0.9-175-g70ef8ee/build/src VERSION=v0.9-175-g70ef8ee modules Error! Bad return status for module build on kernel: 6.12.0-0.rc1.17.fc42.x86_64 (x86_64) Consult /var/lib/dkms/hid-xpadneo/v0.9-175-g70ef8ee/build/make.log for more information.

RaulKong898 avatar Oct 05 '24 10:10 RaulKong898

Please attach this file: /var/lib/dkms/hid-xpadneo/v0.9-175-g70ef8ee/build/make.log.

kakra avatar Oct 05 '24 10:10 kakra

Please attach this file: /var/lib/dkms/hid-xpadneo/v0.9-175-g70ef8ee/build/make.log.

make.log

RaulKong898 avatar Oct 06 '24 13:10 RaulKong898

I can attach a similar make.log. Also from a 6.12-rc kernel, rc2 to be precise.

make.log

kode54 avatar Oct 08 '24 08:10 kode54

Okay, this looks like an incompatibility with kernel 6.12. I'll fix this. Thanks for reporting.

kakra avatar Oct 08 '24 11:10 kakra

Can confirm that there is an issue with the kernel module with this version of the kernel (6.12). Just tried it out on Fedora 41 Beta and it fails to build.

TarsiSurdi avatar Oct 26 '24 19:10 TarsiSurdi

I think i have found a workaround. You can change the code from

static u8 *xpadneo_report_fixup(struct hid_device *hdev, u8 *rdesc, unsigned int *rsize)

to

static const u8 *xpadneo_report_fixup(struct hid_device *hdev, u8 *rdesc, unsigned int *rsize)

Its on line 664 (on nano), the file is at xpadneo/hid-xpadneo/src/hid-xpadneo.c

hithere-at avatar Oct 27 '24 00:10 hithere-at

It'd be nice if got a 0.9.x release with that fix now that kernel 6.12 is released (Edit: or a 0.10.x release would be fine too, but imagine do not want to rush that).

(I received https://bugs.gentoo.org/943776 not long ago, backported the fix so a release is not urgent for us, but it'll be affecting others too)

ionenwks avatar Nov 18 '24 18:11 ionenwks

I've queued some patches here: https://github.com/kakra/xpadneo/commits/queue/for-0.9/

Feel free to test those. I yet want to finalize the remaining hardware support commits before releasing a final v0.9. From there on, v0.10 will restructure a lot of code so it will become impossible to backport patches from v0.10 to v0.9. So I want to let that settle first.

kakra avatar Nov 18 '24 21:11 kakra

I've queued some patches here: https://github.com/kakra/xpadneo/commits/queue/for-0.9/

Seems to be missing commit 242e9b46bb's addition of #include <linux/version.h> to xpadneo.h which is needed for the 6.12 commit (I've added that to my own backport in Gentoo).

Beside that seems fine at a glance, albeit I don't really use/test 0.9.x much myself (I've been using the master branch without issues for a while for my own gamepad -- which is updated to latest every kernel bumps I do -- but most normal Gentoo users use the releases).

ionenwks avatar Nov 18 '24 21:11 ionenwks

Seems to be missing commit 242e9b4's addition of #include <linux/version.h> to xpadneo.h which is needed for the 6.12 commit (I've added that to my own backport in Gentoo).

Good find. For some reason, the same patch builds just fine in master. I will fix that.

kakra avatar Nov 18 '24 21:11 kakra

hi. it seems im having this problem since kernel 6.13.8 on fedora 41. It makes the kernel panic on boot.

heres the make.log

smilodon-gihub avatar Apr 04 '25 15:04 smilodon-gihub

Kernel: 6.15.10 OS: Fedora 42

I can confirm that I noticed something similar to what @smilodon-gihub mentioned. On login screen, after reboot, following driver installation, the screen froze and the fans started making noise. So immediately forced shutdown, rebooted to a safe environment and restored last system snapshot.

ndbhamvani avatar Aug 21 '25 22:08 ndbhamvani