webapis-playground icon indicating copy to clipboard operation
webapis-playground copied to clipboard

✨ [New Demo Request]: Contact Picker API Demo

Open atapas opened this issue 3 years ago • 8 comments

Please include the request by answering these questions.

What is the Example and Demo Topic?

Contact Picker API

Please explain why do you need it?

It works on mobile devices and Opera so far. It would be great to get this demo done.

Any Links, Reads?

https://developer.mozilla.org/en-US/docs/Web/API/Contact_Picker_API

If you are picking up this request to implement, PLEASE READ THIS

atapas avatar Oct 28 '21 03:10 atapas

Hi @atapas, I would love to contribute to this. Can you please assign this to me?

ShivamArora avatar Nov 07 '21 11:11 ShivamArora

Thanks for assigning this to me @atapas. I've generated the boilerplate using the gen-demo script.

However, it seems like there's two different conventions in the code at the moment.

The data is stored at two different places modules/apis/data.ts and utils/demos.js.

There are two different modules in the repo web-apis and modules.

And although the repo mentions we can use either typescript/javascript, it seems all the pages have been written in Javascript.

Also, the gen-demo script doesn't generate boilerplate required within the pages directory.

Can you please help in clarifying which files are being currently used and if the project is undergoing a migration, which folder/files are to be deprecated so I don't write my code in those files?

ShivamArora avatar Nov 07 '21 12:11 ShivamArora

Hey @ShivamArora,

I'm off of a medical leave. @mverissimo @niteshseram @max-programming will be able to help you out.

atapas avatar Nov 07 '21 12:11 atapas

No worries. Take care @atapas 😃

ShivamArora avatar Nov 07 '21 12:11 ShivamArora

Thanks for assigning this to me @atapas. I've generated the boilerplate using the gen-demo script.

However, it seems like there's two different conventions in the code at the moment.

The data is stored at two different places modules/apis/data.ts and utils/demos.js.

There are two different modules in the repo web-apis and modules.

And although the repo mentions we can use either typescript/javascript, it seems all the pages have been written in Javascript.

Also, the gen-demo script doesn't generate boilerplate required within the pages directory.

Can you please help in clarifying which files are being currently used and if the project is undergoing a migration, which folder/files are to be deprecated so I don't write my code in those files?

The codebase is being refactored to typescript and will be merged soon, you can write in js or ts but our preference is ts, will need to update the plopfile to generate js too.

mverissimo avatar Nov 07 '21 19:11 mverissimo

Hi @mverissimo, I was writing my code in Typescript only but seems some components(DemoInfo, DemoSEO) are still written in JS using the older schema for demo [ùtils/demos.js] and are pretty heavily dependent on that older schema making the newer schema useless since we've to duplicate our code for older schema as well.

Is it going to change anytime soon so we can avoid that duplication?

ShivamArora avatar Nov 11 '21 16:11 ShivamArora

Also, please correct me if I'm missing something that can help avoid code duplication.

ShivamArora avatar Nov 11 '21 16:11 ShivamArora

Also, please correct me if I'm missing something that can help avoid code duplication.

The project was refactored, I suggest you start your demo from the develop branch, to avoid these problems.

mverissimo avatar Nov 13 '21 22:11 mverissimo