dragon-mounts icon indicating copy to clipboard operation
dragon-mounts copied to clipboard

Will there be a 1.11.2 update?

Open JancxBaron opened this issue 7 years ago • 6 comments

Well the title explains it all! I REALLY love this mod, and i am so sad and salty that it isn't updated! Do you think it's possible to get it updated for 1.11.2? <3

JancxBaron avatar Mar 21 '17 20:03 JancxBaron

I created a branch for 1.11.2, but there are some issues left that I can't fix yet. I have uploaded the branch, in case anyone would like to help.

ata4 avatar Mar 26 '17 21:03 ata4

I think I fixed a few things. In DragonMoveHelper:75, dragon.move(MoverType.SELF, dragon.motionX, dragon.motionY, dragon.motionZ); In BlockDragonBreedEgg:61, public void getSubBlocks is not an override method Same for protected void rotateCorpse in DragonRenderer:186 I can't yet figure out the BlockPos issue that came up in the Ice and Forest breeds and DragonBreedHelper, but it looks like it's probably just a name change like the worldObj.

JonL98 avatar Mar 28 '17 01:03 JonL98

Actually, I'm not 100% sure about the two override issues, but they did compile.

JonL98 avatar Mar 28 '17 01:03 JonL98

The strange thing about getSubBlocks and rotateCorpse is that the signatures are still the same for both and they are accessible from within the extending class, yet the compiler complains that they don't actually override anything.

And I remember adding MoverType.SELF to that line as well... I'll check if I forgot to push a commit.

ata4 avatar Mar 28 '17 10:03 ata4

@ata4 Any news regarding this?

Sunconure11 avatar Jul 16 '17 02:07 Sunconure11

I could manage to get it compiled for the 1.11.2 version.

Comparing the code of earlier minecraft versions, the method rotateCorpse seems to be moved to RenderLivingBase.applyRotations so when overriding this one instead it worked. Then the signature for getSubBlocks can be fixed as getSubBlocks(Item, CreativeTabs, NonNullList<ItemStack>) Afterwards the mod Id should be changed to have lowercase letters only in DragonMounts.java and in the mcmod.info, otherwise Minecraft will refuse to load the mod.

Then it works and the dragon is rideable. But I didn't test other things, like growing or breeding.

ghost avatar Aug 25 '17 18:08 ghost