Pinglei Guo comments

Results 198 comments of


                                            Pinglei Guo

[log][generator][go] Generate file line number for logging to avoid calling runtime

I should implement logger using `runtime` first, also clean up things like fields before dig into this ...

[log][generator][go] Generate file line number for logging to avoid calling runtime

@halink0803 the merged one is using `runtime` library, not generating line number at compile time like C (so it still has the overhead like most other logging libraries), an example...

[human] Humanize

put into backlog

[util][netutil] Port wait from it from benchhub

The original code is at https://github.com/benchhub/benchhub/tree/master/_legacy/lib/waitforit Also found a interesting one in https://github.com/dyweb/go.ice/issues/56 https://github.com/testcontainers/testcontainers-go/tree/master/wait Might have a dedicated wait package and have `gommon wait` and a dedicated `cmd/waitforit` (or maybe...

[testx] Enhanced test result collection and benchmark dashboard

This is kind of duplicated w/ benchhub's gotest and gobench framework, though it might be better to have benchhub wraps a grpc interface around gommon's functionalities

[testx] Enhanced test result collection and benchmark dashboard

See https://github.com/benchhub/benchhub/issues/54

[go] goimport that check and replace specific import

I should be part of #75

[go] goimport that check and replace specific import

Found one linter from m3db https://github.com/m3db/build-tools/tree/master/linters/importorder

[go] goimport that check and replace specific import

Also there is one checking if specific import is allowed https://github.com/fatih/faillint

[go] goimport that check and replace specific import

Source of goimports https://github.com/golang/tools/blob/master/cmd/goimports/goimports.go