Elizabeth Mitchell comments

Results 221 comments of


                                            Elizabeth Mitchell

docs(list): Fix tables formatting in README

Adding @patrickrodee as a reviewer

[MDCTextField] Input background color problem when autofilled and top border is visible on label background when mdc-floating-label--float-above used

Thanks for the issue! We're investigating this internally as well

[mdc-icon-button] Icon button does not set colors based on theme values properly

I'll be bringing up this issue with the team during our triage meeting this week. We should have an answer tomorrow 🙂

[mdc-icon-button] Icon button does not set colors based on theme values properly

We definitely think this could be addressed. Adding it to our backlog to investigate

[mdc-floating-label] shake-keyframes generates invalid CSS

This could be solved by changing the expression to `calc(0% - #{$positionX})` and adding a unit to the `0`. This might be a bit moot with upcoming changes to text...

First-class plain CSS functions

> I have started work on a proposal for this: #3446 That's awesome! We'll be following closely :D

Validator do not allow customError

I think this could be supported by changing this line in the constraint validation mixin to also check the `Validator`'s computed custom error: ```ts const customError = !!this[privateCustomValidationMessage] || validity.customError;...

anchor of md-menu doesn't support id that starts with digits

Nice catch! Let's go with the CSS.escape route since the ids may be in a ShadowRoot (no getElementById there). Want to try putting together a PR? :)

anchor of md-menu doesn't support id that starts with digits

Open to other contributors too! I hope to get a contribution guide up soon to help folks out

Switch and Checkbox is not updated when reverted in change event

Thanks for the detailed issue! We have plans to move the switch's aria to its host and remove the inner `` implementation. I think as a side effect, that will...