website icon indicating copy to clipboard operation
website copied to clipboard

feat: new community section from community branch

Open akshatnema opened this issue 2 years ago • 5 comments

Description This PR adds a new page to the website which describes all the community-related information and announcements in it. This PR is made draft to track the changes done in the community branch. Whoever wants to contribute to this issue/PR has to make a branch from community branch to his forked repo.

Related issue(s) Resolves #903

akshatnema avatar Aug 25 '22 15:08 akshatnema

Deploy Preview for asyncapi-website ready!

Name Link
Latest commit 4c43126b7b70e896f590463b984615eaea9fc38d
Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/64253cd23e19a70008b46046
Deploy Preview https://deploy-preview-917--asyncapi-website.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 25 '22 15:08 netlify[bot]

@AceTheCreator, the PR for community section is initiated again and you can now track the changes made in the branch, with respect to the master branch.

Regarding resolving the conflicts, I would tag @magicmatatjahu @derberg for this. Which method we should use, directly make a merge commit to the communtiy branch or we should initialize a PR for this to track what changes are made during the merge command in the branch?

akshatnema avatar Aug 25 '22 15:08 akshatnema

any is good, really, it is merged into feature branch anyway, so if something is broken with solving conflicts, it can also be fixed as a followup.

I say, if easier for you is to do it directly to community branch, then do it. @magicmatatjahu ?

derberg avatar Aug 29 '22 12:08 derberg

@derberg what happened to the previous PR that got merged into the community branch?

AceTheCreator avatar Aug 29 '22 13:08 AceTheCreator

what happened to the previous PR that got merged into the community branch?

@AceTheCreator it got merged as you noticed 😄 https://github.com/asyncapi/website/pull/902

derberg avatar Aug 29 '22 13:08 derberg

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 41
🟠 Accessibility 88
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-917--asyncapi-website.netlify.app/

github-actions[bot] avatar Feb 08 '23 18:02 github-actions[bot]

This PR is ready for a final review; kindly have a look @derberg @alequetzalli @akshatnema

AceTheCreator avatar Feb 28 '23 10:02 AceTheCreator

Final review remarks in case of user journey

  • IMHO 👇🏼 should not be there and just clicking on Community should take you to overview, just like clicking on Docs or Tools in the top navigation works Screenshot 2023-02-28 at 13 31 59
  • going further with list of items there, when you expand Community section. There is still old Meetings item, and the content. The new events should be meetings as before. So current Meetings item leave as it is, remove whatever is shown after going to /meetings and replace with what you already have under /events
  • There is no navigation iteam among the ones I mention above that would take me to /ambassadors
  • There is one problem I have with whatever I see when going to /community. There are highlights only of items that you added in this PR. But what about TSC? contributor dashboard? newsroom?
  • Imho you can remove tools&services from under community as main tools navigation item already takes people there

derberg avatar Feb 28 '23 12:02 derberg

  • There is one problem I have with whatever I see when going to /community. There are highlights only of items that you added in this PR. But what about TSC? contributor dashboard? newsroom?

Sorry, I need more context about this

AceTheCreator avatar Mar 01 '23 11:03 AceTheCreator

the thing is that when you go to /community, to a kinda Community Landing Page, you see it promotes:

  • discussions
  • ambassadors
  • meetings
  • slack
  • goals and upcoming work

but when you look at: Screenshot 2023-03-01 at 13 42 24

there are some additional community items that are not promoted on landing page


so in short I think the idea behind /community view should be to highlight all the items that people can find there.

makes sense? not a must-have for me in this PR but if we have an agreement we should definitely have a dedicated followup issue on that

derberg avatar Mar 01 '23 12:03 derberg

the thing is that when you go to /community, to a kinda Community Landing Page, you see it promotes:

  • discussions
  • ambassadors
  • meetings
  • slack
  • goals and upcoming work

but when you look at: Screenshot 2023-03-01 at 13 42 24

there are some additional community items that are not promoted on landing page

so in short I think the idea behind /community view should be to highlight all the items that people can find there.

makes sense? not a must-have for me in this PR but if we have an agreement we should definitely have a dedicated followup issue on that

I understand now. But i thought keeping the landing page simple and straightforward was a really good approach.

I can create a separate issue and make someone contribute to it :)

What do you think @alequetzalli?

AceTheCreator avatar Mar 01 '23 13:03 AceTheCreator

I understand now. But i thought keeping the landing page simple and straightforward was a really good approach. I can create a separate issue and make someone contribute to it :)

What do you think @alequetzalli?

Uh oh... do I have to answer this one? 😄 Can't I just agree with everyone? 😂😂😂😂 LOL kidding...

Ok, so tbh here's my take:

  1. I agree with @derberg on his concern over the Community item's behavior in the nav bar; I too would expect to be allowed to click on it and have it take me directly to the landing page.
  2. I happen to feel that the current Community landing page feels too marketing-like. IOW... full of pretty colors and graphics, but not necessarily have the information I need as a community member. I also think that Lukasz makes a good point about that page currently missing the most context of what community members will look for there... my vote is to fix that page because it currently does not serve the community as well as it could. ♥️

quetzalliwrites avatar Mar 02 '23 03:03 quetzalliwrites

Any other suggestions? cc @derberg @akshatnema @alequetzalli

AceTheCreator avatar Mar 16 '23 13:03 AceTheCreator

@AceTheCreator can you fix merge conflicts first 🙏🏼

derberg avatar Mar 16 '23 15:03 derberg

@AceTheCreator can you fix merge conflicts first 🙏🏼

@akshatnema your help is needed :)

AceTheCreator avatar Mar 16 '23 15:03 AceTheCreator

The videos in the list are not sorted according to the ascending order of dates, like the meeting of 20th March should be displayed first and then further meetings should be displayed according to the dates.

@akshatnema you're right akshat

AceTheCreator avatar Mar 20 '23 10:03 AceTheCreator

It's not possible for me to review this PR as a whole from the codebase point of view as there are around 2k lines of changes. So, we will make sure we won't be dealing with any such PR in the future and will review each individual PR despite having the thoughts that we can improve it later.

@akshatnema I disagree with this approach, as it only prolongs this PR. So I'll advise you to create the review once, and whatever thing you find out later on can be opened as a GFI. Your approach will only keep making me open more PR fixing small changes

AceTheCreator avatar Mar 20 '23 11:03 AceTheCreator

@akshatnema I disagree with this approach, as it only prolongs this PR. So I'll advise you to create the review once, and whatever thing you find out later on can be opened as a GFI. Your approach will only keep making me open more PR fixing small changes

Sorry, but actually you misunderstood my concern slightly. I'm not asking to make new PRs to make small changes in this PR. But what I said that when you had initialized individual PRs for the pages of the community section previously, I must have made a complete review for that PR instead of waiting for them to merge in the community branch. Anyways, my reviews are done. Approved :heavy_check_mark:. Waiting for the approval from @derberg @alequetzalli

akshatnema avatar Mar 26 '23 15:03 akshatnema

@alequetzalli, any other suggestion from your end? Before we go ahead merge this PR

AceTheCreator avatar Mar 28 '23 21:03 AceTheCreator

@AceTheCreator Will you like to merge the PR? Since, you are the major contributor of this PR and I want you to take this pleasure. Just do the / rtm command in this PR :smile:

akshatnema avatar Mar 29 '23 18:03 akshatnema

/rtm

AceTheCreator avatar Mar 30 '23 08:03 AceTheCreator