website
website copied to clipboard
feat: press page
Hello Everyoneπ. Heyy @derberg , @magicmatatjahu, @Barbanio , @mcturco. This PR is the second part the Footer Update PR
#808 and related to the issue #195. So as of now and as per discussions with @derberg , the press kit was added and being rendered at /press
(URL) which will be linked to the press
tab in the footer.
ToDo:
- [x] Add main content (press kit)
- [x] ~~Add index~~ (not required, as per discussion on slack)
- [x] Move OpenGovernanceModel and History to
About
page
Please take a look at it. Eagerly waiting for your suggestions.
Thank youπ
Deploy Preview for asyncapi-website ready!
Built without sensitive environment variables
Name | Link |
---|---|
Latest commit | 7c7826b9ce7ce04954c2d76eccf1b2f323dfa403 |
Latest deploy log | https://app.netlify.com/sites/asyncapi-website/deploys/631accc60f8df100083adc07 |
Deploy Preview | https://deploy-preview-828--asyncapi-website.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
β‘οΈ Lighthouse report for the changes in this PR:
Category | Score |
---|---|
π΄ Performance | 34 |
π Accessibility | 88 |
π Best practices | 83 |
π’ SEO | 90 |
π΄ PWA | 30 |
Lighthouse ran on https://deploy-preview-828--asyncapi-website.netlify.app/
Hey @Harish-b-13 π , looking on to the page /press/index.js
, is this a type of article/blog on the website to inform users about Press?
Heyy @akshatnema , Kindly please go through this conversation (initial ones, where @Barbanio explained about this). Just to give a short explanation, (given by Barbanio)
The idea is to make it easier to access the information most relevant to journalists in one tab.
it's very common for any company, enterprise, or project to have a press kit, it is very important in terms of public relations and communication. It's a document that gathers all the relevant information of the project (mission, objectives, values, etc.), it could be said that it is the letter of introduction.
And there will be two tabs for this: press releases
(annual report kinda thing and compilation of news) and press kit
(the document with general info about AsyncAPI Initiative which Γlex and Barbino worked on)
I think, better people to answer about this would be: @derberg and @Barbanio
Thank youπ
Hi @akshatnema! Yes, it's exactly what @Harish-b-13 explains in his comment π
@Harish-b-13 @Barbanio Yeah, I completely got it about the information we need to show on the page, but my suggestion is regarding UI. If we aren't implementing any functionality and want the information to be conveyed in a good way, I think you can use the format just like blogs. Make a .md
files for the information that need to be conveyed and it will automatically get converted to JSX
along with the TOC to enable good referencing. But if your plan is to have some good functionalities like Contact (mail) need to be added later, the present implementation is brilliant.
What I can see right now is a page full of important information and headings, just like the articles in AsyncAPI. I hope that you can understand my concern and give your views regarding this.
Heyy @akshatnema
So AFAIK, in future, press
will be having Press-releases, compilation of news/articles and Press kit. In my opinion, it would be better if it is .js
format so that we can have more flexibility in the layout.
@derberg @Barbanio Please let me know your thoughts regarding this π
Thank youπ
@akshatnema @Harish-b-13 I have no idea about the technical side, but I think it makes sense to do it the way that allows more options in the future.
actually, I think long term if we extend it to something more than just one page, to make it easier to contribute, .md
. But it is ok to do .js
first. No strong opinion though
my only concern is the content for the press
page, as it is a kind of mix of press
and about
or is it a standard now that about
pages are not created and all is under press
?
examples:
- about https://www.postman.com/company/about-postman/
- press https://www.postman.com/company/press-media/
so part for example about governance is great, but shouldn't it be in About, along with history?
so part for example about governance is great, but shouldn't it be in About, along with history?
Yes @derberg , I think you are right. This makes sense.
Heyy @derberg @Barbanio , have removed Open Governance Model and history from press
page as suggested and moved Open Governance Model to about
page. But, I didnt add history to about
page as it is already there.
Please check once and give your suggestions
Thank youπ
@Harish-b-03 This looks great. Thank you very much! ππ
I have a question. Finally, will it be modified the maintainers' section?
@Barbanio as @derberg suggested, we have to change the maintainers' section. That is pending till now.
But I dont know much about the works going on in AsyncAPI, as I joined just a month before. Maybe if u have any idea or if you could help me with that, would be very helpfulπ.
@derberg how we are going to update the about
page. Do you have any plan?.
@derberg @Barbanio I think, press
page is completed. is there any thing have to be changed. please let me know
Thank youπ
But I dont know much about the works going on in AsyncAPI, as I joined just a month before. Maybe if u have any idea or if you could help me with that, would be very helpfulπ.
@Harish-b-03 Of course, I will be happy to work with you on this π
@derberg, the TSC is made up of maintainers, but all maintainers are in the TSC? Where can I check this?
Any special approach to writing this section?
@Barbanio not all maintainers are TSC members, it is not obligatory. You can become a CODEOWNER for one repo and not join TSC like for example guys from https://github.com/asyncapi/tck/blob/master/CODEOWNERS.
We do not have yet one place that lists all maintainers, just TSC members. Would be solved with https://github.com/asyncapi/.github/issues/47#issuecomment-1046222917 but not selected for AsyncAPI Mentorship
How about something like this β¬οΈ to update the maintainers' section?
Committers (also known as maintainers) are the decision-makers at the repository/project level. They regularly contribute to the project and are invited by other maintainers to manage the repository, have more privileges, and approve pull requests.
The committers rule the repository, but for issues that go beyond that, there is a Technical Steering Committee (TSC). This committee comprises all the maintainers who voluntarily want to be part of this committee, thus taking responsibility for overseeing the initiative.
You can check the list of maintainers belonging to the TSC here.
How about something like this β¬οΈ to update the maintainers' section?
LOVE IT β€οΈ I would just not add the last paragraph about growth but just linked to TSC list.
also Maintainers (also known as committers)
should be Committers (also known as maintainers)
Heyy @Barbanio , hope you are doing great!!..
I wanted to ask you that if you need any sort of help for the /about
page please let me know.
I will be happy to help you
Thank you for your feedback @derberg, I have modified the text with your suggestions.
@Harish-b-03, thanks for your willingness :) I would like to have your opinion on this text for the maintainers' section.
Heyy @Barbanio , Its perfect. Let me include it in the 'about' page.
Heyy @derberg @Barbanio @alequetzalli , I have added a short Intro section in About
page, which I got from this blog post. Please have a look at it.
I think both Press
and About
are completed. Eagerly waiting for your suggestions π .
Thank you
@derberg I think it makes sense. This information was written some time ago and some press
data is out of date.
If it is decided to continue with press
and about
, I think it would be interesting to remove the AsyncAPI, in numbers section, since even if it is updated it will always be out of date soon.
Heyy @alequetzalli :grinning: , I have made changes in AsyncAPI in numbers
section. please review it.
I have resolved and made all the changes requested Lukasz . @alequetzalli If you review this section, then I can move the contents to about
page and make press
page to list only the links to Press-releases and articles.
@alequetzalli I request you to review the about
page once again, after i merged the contents.
Thank you :smile:
Heyy @alequetzalli π , I have made changes in
AsyncAPI in numbers
section. please review it.I have resolved and made all the changes requested Lukasz . @alequetzalli If you review this section, then I can move the contents to
about
page and makepress
page to list only the links to Press-releases and articles.@alequetzalli I request you to review the
about
page once again, after i merged the contents.Thank you π
Hey @Harish-b-03 wait... I am not done reviewing yet. I am working right now and have 1/3 left. You need to wait until I finish! hahaha π
Heyy @derberg @alequetzalli @Barbanio :grinning: ,
@derberg , done :+1: :+1: please take look at it.
@derberg @alequetzalli @Barbanio please review the changes and let me know the required changes
Thank you :grin:
Heyy @Barbanio , I have made those changes. please review once again. Thank you :grin:
Heyy @derberg @alequetzalli please review the changes and let me know the required changes. Thank you π
It looks good. Great job @Harish-b-03!
@Harish-b-03 @derberg I saw the /about
route and About
page that is to be added via this PR. My only concern with this is we are not giving any link to this page using Navbar and it is only liked via Footer About
link. I think we may lose the audience for this page as we aren't specifying any section to the press page neither in the Homepage nor in Navbar. Should we add an option inside any dropdown for press
page?