website icon indicating copy to clipboard operation
website copied to clipboard

docs: update the getting started docs page

Open Annysah opened this issue 2 years ago • 15 comments

Description

  • Updated the tutorial outline to be in sync with the given template.

Related issue(s) Fixes #793

Annysah avatar Jun 14 '22 19:06 Annysah

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
Latest commit f5f2cc353e220542edf5e85bd2cadeb8a2978493
Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/63291b5e50db940008b19035
Deploy Preview https://deploy-preview-825--asyncapi-website.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Jun 14 '22 19:06 netlify[bot]

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 27
🟢 Accessibility 95
🟠 Best practices 83
🟢 SEO 90
🔴 PWA 30

Lighthouse ran on https://deploy-preview-825--asyncapi-website.netlify.app/

github-actions[bot] avatar Jun 14 '22 19:06 github-actions[bot]

Good start @Annysah! tadatadatada

Let's go for Draft 2. heart

Thanks Ale for the reviews, I will get to work!

Annysah avatar Jul 01 '22 12:07 Annysah

Hi @alequetzalli,

Just submitted the second draft.

Annysah avatar Jul 02 '22 10:07 Annysah

In addition to the requested changes, I added a section "Generating the docs".

Would it be a necessary addition?

Annysah avatar Jul 02 '22 10:07 Annysah

sure, I'll definitely have a look, but please first solve the merge conflicts, and then ping me again so I know it is ready for review (sometimes things get messy during solving conflicts, so better if i look after)

derberg avatar Jul 06 '22 07:07 derberg

sure, I'll definitely have a look, but please first solve the merge conflicts, and then ping me again so I know it is ready for review (sometimes things get messy during solving conflicts, so better if i look after)

Alright @derberg, I will work on resolving it.

Thank you!

Annysah avatar Jul 07 '22 11:07 Annysah

Afaik the document that you edit here in this PR is https://www.asyncapi.com/docs/tutorials/getting-started and I'm not 100% sure we really want to turn it into a tutorial. I think this should be a kind of intro to getting started, so it is now.

now this document at the same time contains a general explanation of AsyncAPI goal (was there before) and some step-by-step explanation on how to create an AsyncAPI document + generate docs for it. Technically your instructions are very accurate but was it the goal.

..........

@derberg Ok dude.... First, this is SO CONFUSING in the way you wrote it, you need to slow down and breathe before you reply to stuff. 😝 (just explaining cause you really confused poor @Annysah, so I am trying to help clarify to her what you said 😄✌🏽)

Second, Seeing what Anisat wrote in her 2nd draft here + thinking of your feedback Lukasz, I am inclined to agree that this Getting Started is really a quickstart, and not a tutorial. If yes, if we consider it a quickstart, that also means the TW outline is not going to be the same as the outline for a tutorial and thus does not need to change.

So IOW @Annysah, what Lukasz was expressing is that what you wrote/added in this PR is technically accurate, BUT potentially did not make sense to incorporate because his take was that this piece of TW content was not a tutorial. (Now you can see why I emphasized so much in the previous paragraph that I agreed this was a quickstart to the technology of AsyncAPI.)

Since a quickstart to the technology of AsyncAPI is a different kind of TW content, the goals and outline will be different than that which is needed for a tutorial that explains things you can do with the technology of AsyncAPI. 😀✌🏽

Lastly, what this means is that I don't think we actually need to merge this PR and it actually makes sense to close it, Anisat. 😀✌🏽 This doesn't mean you didn't do a GOOD job! I think it was pretty good and like Lukasz even himself said, what you added was technically correct. And that's always a good thing! haha 😎 Essentially, Lukasz was just seeing that this is one of those PRs that after the fact, you happen to realize is not the best idea to merge for a project. Not a big deal and it was still SUPER GOOD to have you practice writing and getting more familiar with AsyncAPI. 😀❤️

let me know if this makes sense now 😀 @Annysah! and I think it could be as simple as us closing this PR (unless lukasz had diff thoughts) and then we identify a new task for you (which there is! hahaha trust meee)

maybe let's go back to #793 and clarify the scope there? @alequetzalli thoughts?

No lukasz, the scope there is clear; it's a tutorial update with new outline template. I think you just got confused because you don't think of this as a tutorial. (which we agree on hahaa)

quetzalliwrites avatar Jul 12 '22 22:07 quetzalliwrites

ups, sorry for being confusing. I actually did not rush with my comment, on a contrary, I tried to be as detailed as possible to express my confusion 😆 because the content, as I wrote, was technically accurate, but the location was confusing and I could not figure much from linked issue.

I think it is a good idea to have a kind of tutorial, that is super straightforward, just few steps, from creating a file to generating docs. Let's just first discuss the scope in an issue first, because for example I think it would be lovely to use AsyncAPI CLI for it, where you have the asyncapi new command and with one command you can actually create an AsyncAPI file from existing examples

derberg avatar Jul 14 '22 09:07 derberg

Thank you so much @alequetzalli for the clarifications. I think I now understand what @derberg means.

@derberg Thank you for the feedback as well!

Annysah avatar Jul 14 '22 11:07 Annysah

ups, sorry for being confusing. I actually did not rush with my comment, on a contrary, I tried to be as detailed as possible to express my confusion 😆 because the content, as I wrote, was technically accurate, but the location was confusing and I could not figure much from linked issue.

I think it is a good idea to have a kind of tutorial, that is super straightforward, just few steps, from creating a file to generating docs. Let's just first discuss the scope in an issue first, because for example I think it would be lovely to use AsyncAPI CLI for it, where you have the asyncapi new command and with one command you can actually create an AsyncAPI file from existing examples

Is the AsyncAPI CLI the same as the studio?

Annysah avatar Jul 14 '22 11:07 Annysah

@Annysah CLI is something that you use in the terminal -> https://www.asyncapi.com/tools/cli

so for example after installing CLI, when you run asyncapi new --file-name=asyncapi.yml --example=default-example.yaml --no-tty in the terminal, the new AsyncAPI file is immediately generated for you

derberg avatar Jul 18 '22 09:07 derberg

So I was thinking in addition to creating a tutorial on how to get started with AsyncAPI using the CLI, we could also possibly restructure the outline of the "Getting Started" section.

Here is a link to a draft of an outline idea I worked on: https://hashnode.com/preview/62cffe97466c6ad9ff5d96c2

cc: @alequetzalli @derberg @starlightknown @nelsonmic @pratik2315 @Florence-Njeri @thulieblack

Annysah avatar Jul 19 '22 13:07 Annysah

So I was thinking in addition to creating a tutorial on how to get started with AsyncAPI using the CLI, we could also possibly restructure the outline of the "Getting Started" section. Here is a link to a draft of an outline idea I worked on: https://hashnode.com/preview/62cffe97466c6ad9ff5d96c2

Oh lukaszzzz we especially wanted your thoughts on it! 😀

@derberg

quetzalliwrites avatar Jul 20 '22 00:07 quetzalliwrites

I have some concerns with the outline, basically what we lose, and we had so far:

  • we have https://www.asyncapi.com/docs/tutorials/getting-started/hello-world now, and I like it by it's super simple step-by-step approach when you highlight each section of AsyncAPI document and explain what it is. I do not see it in your Create an AsyncAPI Document, where you show the entire document end explain each part of it in one big paragraph. I prefer the approach from the current hello-world, or the other approach I used in the online workshop, where I add each section with additional explanations one by one. As this is for me a nature of a guide.
  • Generate the Docs -> you propose to have a guide about docs generation but then there are more things users add to AsyncAPI document. At least this is how I understand the outline, that some basics first, then docs generation and then other AsyncAPI concepts (like security). I'm not 100% supporting this approach as docs generation is more "complex" (not by difficulty but flexibility) as there are more options to generate docs except for just ag command. So Generate the Docs would rather be an intro to a few other tutorials that explain how to do docs generation client side, server side, on a CI, react app, etc 😄 I assume your intention was to show the benefits to the user quickly. But we can do this by telling from the start that they should create a file in https://studio.asyncapi.com/ or VSCode with plugins or using CLI - what you already did. So maybe to make it more explicitly we should have it as part of instructions? like go to https://studio.asyncapi.com/ or install AsyncAPI CLI and run asyncapi open studio?

I love to see tutorials will not only be about writing AsyncAPI document but also how to convert it into docs ❤️ What is you proposal for Streetlights tutorial, as it kinda repeats Getting Started and then ends with code generation. I think it should also be mixed with new outline. So we have:

  1. Write AsyncAPI document
  2. Generate docs - new
  3. Generate code - Streetlight tutorial modified

derberg avatar Jul 25 '22 16:07 derberg

It looks like we don't have sufficient reason to continue this one, so let's close this PR and leave our Quickstart as is. ✌🏽

quetzalliwrites avatar Sep 20 '22 01:09 quetzalliwrites