website icon indicating copy to clipboard operation
website copied to clipboard

fix: normalized logos of sponsors

Open Wck-iipi opened this issue 1 year ago • 10 comments

image Screen Shot 2024-08-29 at 00 49 25 Screen Shot 2024-08-29 at 00 49 19

Description

  • Normalized logos of sponsors.

Related issue(s)

Fixes #3158

Summary by CodeRabbit

  • New Features

    • Introduced a new ResponsiveImage component for improved image handling across sponsor sections.
    • Replaced standard <img> tags with the ResponsiveImage component in Gold, Silver, and general Sponsors sections.
  • Bug Fixes

    • Updated data-testid attributes to dataTestId for consistency and improved testing capabilities.

Wck-iipi avatar Aug 28 '24 19:08 Wck-iipi

Deploy Preview for asyncapi-website failed.

Built without sensitive environment variables

Name Link
Latest commit 3d6219002bd5f5df4a005e95fdffd6df8e2229bf
Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/6757ed69cb32d9000814631e

netlify[bot] avatar Aug 28 '24 19:08 netlify[bot]

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 38
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-3169--asyncapi-website.netlify.app/

asyncapi-bot avatar Aug 28 '24 19:08 asyncapi-bot

@akshatnema I have made the changes can you please check this PR. Thanks.

Wck-iipi avatar Oct 10 '24 18:10 Wck-iipi

@coderabbitai summarize

akshatnema avatar Oct 11 '24 12:10 akshatnema

[!TIP] For best results, initiate chat on the files or code changes.

@akshatnema, here's the summary of the PR:

Fix: Normalized Logos of Sponsors

This pull request addresses issue #3158 by normalizing the logos of sponsors on the AsyncAPI website. The changes ensure that all sponsor logos are adjusted for consistent appearance, improving the overall look and feel of the sponsors section.

coderabbitai[bot] avatar Oct 11 '24 12:10 coderabbitai[bot]

@Wck-iipi Please resolve the conflicts in your PR.

akshatnema avatar Oct 11 '24 12:10 akshatnema

@coderabbitai full review

akshatnema avatar Oct 11 '24 12:10 akshatnema

:white_check_mark: Actions performed

Full review triggered.

coderabbitai[bot] avatar Oct 11 '24 12:10 coderabbitai[bot]

Walkthrough

The changes involve the introduction of a new ResponsiveImage component to standardize the rendering of sponsor logos across various components. The <img> tags in GoldSponsors.tsx, SilverSponsors.tsx, and Sponsors.tsx have been replaced with the new ResponsiveImage component, which accepts specific attributes for improved responsiveness and consistency. The data-testid attribute has been updated to dataTestId for uniformity.

Changes

File Path Change Summary
components/sponsors/GoldSponsors.tsx Introduced ResponsiveImage, replaced <img> with <ResponsiveImage> using src, alt, className, and dataTestId. Changed data-testid to dataTestId.
components/sponsors/ResponsiveImage.tsx Added ResponsiveImage component with props: src, alt, className, dataTestId. Merged Tailwind CSS classes and returned an <img> element. Added interface and default export.
components/sponsors/SilverSponsors.tsx Introduced ResponsiveImage, replaced <img> with <ResponsiveImage> using src, alt, className, and dataTestId. Changed data-testid to dataTestId. Updated method signature.
components/sponsors/Sponsors.tsx Introduced ResponsiveImage, replaced <img> with <ResponsiveImage> using src, alt, className, and dataTestId. Changed data-testid to dataTestId. Updated method signature.

Assessment against linked issues

Objective Addressed Explanation
Normalize the logos of sponsors (#3158)

🐇 In the meadow, logos shine bright,
With ResponsiveImage, all just right.
No more giants, just a neat view,
Tailwind's magic, making it new!
Hop along, sponsors, in a row,
Together we flourish, watch us grow! 🌼


📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between fa4eae339cd08f907caeaf45b6681e9f90ac046e and 9008f6c50315264210b7b2fa3ce9eb1a3a6a6d9a.

📒 Files selected for processing (3)
  • components/sponsors/GoldSponsors.tsx (2 hunks)
  • components/sponsors/SilverSponsors.tsx (2 hunks)
  • components/sponsors/Sponsors.tsx (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
  • components/sponsors/GoldSponsors.tsx
  • components/sponsors/SilverSponsors.tsx
  • components/sponsors/Sponsors.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Oct 11 '24 12:10 coderabbitai[bot]

@akshatnema I have resolved the conflict and made alt a compulsory attribute for accessibility purposes. Please review this PR.

Wck-iipi avatar Oct 16 '24 11:10 Wck-iipi

@Wck-iipi are you still owrking on this

sambhavgupta0705 avatar Dec 10 '24 07:12 sambhavgupta0705

/update

sambhavgupta0705 avatar Dec 10 '24 07:12 sambhavgupta0705

closing this as no response

sambhavgupta0705 avatar Dec 16 '24 11:12 sambhavgupta0705