website
website copied to clipboard
fix: normalized logos of sponsors
Description
- Normalized logos of sponsors.
Related issue(s)
Fixes #3158
Summary by CodeRabbit
-
New Features
- Introduced a new
ResponsiveImagecomponent for improved image handling across sponsor sections. - Replaced standard
<img>tags with theResponsiveImagecomponent in Gold, Silver, and general Sponsors sections.
- Introduced a new
-
Bug Fixes
- Updated
data-testidattributes todataTestIdfor consistency and improved testing capabilities.
- Updated
Deploy Preview for asyncapi-website failed.
Built without sensitive environment variables
| Name | Link |
|---|---|
| Latest commit | 3d6219002bd5f5df4a005e95fdffd6df8e2229bf |
| Latest deploy log | https://app.netlify.com/sites/asyncapi-website/deploys/6757ed69cb32d9000814631e |
⚡️ Lighthouse report for the changes in this PR:
| Category | Score |
|---|---|
| 🔴 Performance | 38 |
| 🟢 Accessibility | 98 |
| 🟢 Best practices | 92 |
| 🟢 SEO | 100 |
| 🔴 PWA | 33 |
Lighthouse ran on https://deploy-preview-3169--asyncapi-website.netlify.app/
@akshatnema I have made the changes can you please check this PR. Thanks.
@coderabbitai summarize
[!TIP] For best results, initiate chat on the files or code changes.
@akshatnema, here's the summary of the PR:
Fix: Normalized Logos of Sponsors
This pull request addresses issue #3158 by normalizing the logos of sponsors on the AsyncAPI website. The changes ensure that all sponsor logos are adjusted for consistent appearance, improving the overall look and feel of the sponsors section.
@Wck-iipi Please resolve the conflicts in your PR.
@coderabbitai full review
:white_check_mark: Actions performed
Full review triggered.
Walkthrough
The changes involve the introduction of a new ResponsiveImage component to standardize the rendering of sponsor logos across various components. The <img> tags in GoldSponsors.tsx, SilverSponsors.tsx, and Sponsors.tsx have been replaced with the new ResponsiveImage component, which accepts specific attributes for improved responsiveness and consistency. The data-testid attribute has been updated to dataTestId for uniformity.
Changes
| File Path | Change Summary |
|---|---|
| components/sponsors/GoldSponsors.tsx | Introduced ResponsiveImage, replaced <img> with <ResponsiveImage> using src, alt, className, and dataTestId. Changed data-testid to dataTestId. |
| components/sponsors/ResponsiveImage.tsx | Added ResponsiveImage component with props: src, alt, className, dataTestId. Merged Tailwind CSS classes and returned an <img> element. Added interface and default export. |
| components/sponsors/SilverSponsors.tsx | Introduced ResponsiveImage, replaced <img> with <ResponsiveImage> using src, alt, className, and dataTestId. Changed data-testid to dataTestId. Updated method signature. |
| components/sponsors/Sponsors.tsx | Introduced ResponsiveImage, replaced <img> with <ResponsiveImage> using src, alt, className, and dataTestId. Changed data-testid to dataTestId. Updated method signature. |
Assessment against linked issues
| Objective | Addressed | Explanation |
|---|---|---|
| Normalize the logos of sponsors (#3158) | ✅ |
🐇 In the meadow, logos shine bright,
WithResponsiveImage, all just right.
No more giants, just a neat view,
Tailwind's magic, making it new!
Hop along, sponsors, in a row,
Together we flourish, watch us grow! 🌼
📜 Recent review details
Configuration used: CodeRabbit UI Review profile: CHILL
📥 Commits
Files that changed from the base of the PR and between fa4eae339cd08f907caeaf45b6681e9f90ac046e and 9008f6c50315264210b7b2fa3ce9eb1a3a6a6d9a.
📒 Files selected for processing (3)
- components/sponsors/GoldSponsors.tsx (2 hunks)
- components/sponsors/SilverSponsors.tsx (2 hunks)
- components/sponsors/Sponsors.tsx (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
- components/sponsors/GoldSponsors.tsx
- components/sponsors/SilverSponsors.tsx
- components/sponsors/Sponsors.tsx
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>, please review it.Generate unit testing code for this file.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:@coderabbitai generate unit testing code for this file.@coderabbitai modularize this function.
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.@coderabbitai read src/utils.ts and generate unit testing code.@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.@coderabbitai help me debug CodeRabbit configuration file.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
@coderabbitai pauseto pause the reviews on a PR.@coderabbitai resumeto resume the paused reviews.@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository.@coderabbitai full reviewto do a full review from scratch and review all the files again.@coderabbitai summaryto regenerate the summary of the PR.@coderabbitai resolveresolve all the CodeRabbit review comments.@coderabbitai configurationto show the current CodeRabbit configuration for the repository.@coderabbitai helpto get help.
Other keywords and placeholders
- Add
@coderabbitai ignoreanywhere in the PR description to prevent this PR from being reviewed. - Add
@coderabbitai summaryto generate the high-level summary at a specific location in the PR description. - Add
@coderabbitaianywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
@akshatnema I have resolved the conflict and made alt a compulsory attribute for accessibility purposes. Please review this PR.
@Wck-iipi are you still owrking on this
/update
closing this as no response