website
website copied to clipboard
asyncapi
feat: setup dark mode for the website
This PR sets up dark mode for the website. The toggle button for it is currently commented out. We can uncomment it after the Tailwind CSS classes for dark mode are added to every page of the website. We will add Tailwind CSS classes to the website incrementally with different PRs for different pages.
@akshatnema @anshgoyalevil @sambhavgupta0705
Deploy Preview for asyncapi-website ready!
Built without sensitive environment variables
| Name | Link |
|---|---|
| Latest commit | 62f5e6d49bdb800dd95c6fe9e199539dd501c1de |
| Latest deploy log | https://app.netlify.com/sites/asyncapi-website/deploys/66a4a0f498463a000855ffcc |
| Deploy Preview | https://deploy-preview-3118--asyncapi-website.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
⚡️ Lighthouse report for the changes in this PR:
| Category | Score |
|---|---|
| 🔴 Performance | 34 |
| 🟢 Accessibility | 98 |
| 🟢 Best practices | 92 |
| 🟢 SEO | 100 |
| 🟠 PWA | 56 |
Lighthouse ran on https://deploy-preview-3118--asyncapi-website.netlify.app/
@vishvamsinh28 I prefer adding the button and basic setup first. We cannot follow this convention of adding tailwind classes one by one One thing you can do is commit changes one by one in your own branch but we cannot follow this policy in the production branch
In production we need to merge whole at once as we did in the case of typescript migration
As you have commented out the button so how will I check the UI of the website??? Cannot approve anything without seeing the UI
@sambhavgupta0705 I did that 4months ago in my PR but @anshgoyalevil @derberg suggested to open incremental PRs
Here's the comment :- https://github.com/asyncapi/website/pull/2650#pullrequestreview-1878396303
After merging this PR, we will have the basic setup for dark mode in the codebase. After that, anyone can work on dark mode locally, open PRs for adding dark mode to different pages, and once we have covered every page, we can uncomment the dark mode button, making it accessible to all users.
@sambhavgupta0705 @anshgoyalevil Let's do this after GSoC. By that time, if no one else has opened a PR for this issue, I will start working on it and complete it.
@vishvamsinh28 hey man, I see you have closed this issue . If you are not currently working on it I would like to take it on. Can I move forward with your code changes and improve it , or someone has already taken over ?
@Sahil-Shadwal We don't have any plans to implement this feature on the website. The issue is closed for the time being.
