website
website copied to clipboard
asyncapi
fix: i18n for smaller screen
Deploy Preview for asyncapi-website ready!
Built without sensitive environment variables
| Name | Link |
|---|---|
| Latest commit | 30f1f30379693c661f7d9a0d7bb33d29b930cadd |
| Latest deploy log | https://app.netlify.com/sites/asyncapi-website/deploys/66d04feabbda9b0008da1243 |
| Deploy Preview | https://deploy-preview-3113--asyncapi-website.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
⚡️ Lighthouse report for the changes in this PR:
| Category | Score |
|---|---|
| 🔴 Performance | 36 |
| 🟢 Accessibility | 98 |
| 🟢 Best practices | 92 |
| 🟢 SEO | 100 |
| 🔴 PWA | 33 |
Lighthouse ran on https://deploy-preview-3113--asyncapi-website.netlify.app/
Can we something like kubevela.io ?? The selector needs to be inside of the dropdown only but we need to improve its UI
Can we something like kubevela.io ?? The selector needs to be inside of the dropdown only but we need to improve its UI
sure, will try to do that !!
@sambhavgupta0705 do the repo has a specific command for linting. the pr seems to be failing due to it. what might be the cause of it. am i missing a step. wouldn't it be better to have a precommit hook for lint staged when we do the commit 🤔 happens same at PR
Can we change the icon in side of language to anything in deutsche
And increase the right margin of en and de also in the drop-down
i believe you mean margin left.. , have given a margin of 2
i believe you mean margin left.. , have given a margin of 2
Yes this only
@sambhavgupta0705 do the repo has a specific command for linting. the pr seems to be failing due to it. what might be the cause of it. am i missing a step. wouldn't it be better to have a precommit hook for lint staged when we do the commit 🤔 happens same at PR
Lint cheeck passed in that PR ,there is a check fail which is because of change in npm and node version .We need to resolve it @akshatnema has more idea about it
@sambhavgupta0705 do the repo has a specific command for linting. the pr seems to be failing due to it. what might be the cause of it. am i missing a step. wouldn't it be better to have a precommit hook for lint staged when we do the commit 🤔 happens same at PR
Lint cheeck passed in that PR ,there is a check fail which is because of change in npm and node version .We need to resolve it @akshatnema has more idea about it
sure , will wait for the response from his side..
can we decrease the font size of the EN DE here
currently it is set to text-base, should we go with sm or xs
currently it is set to text-base, should we go with sm or xs
For smaller screen yes and
remove this whitespace also
@Mayaleeeee Can you please take a look at this
Hello @TenzDelek @sambhavgupta0705, Instead of using codes like 'en' and 'de', let's use terms people are more familiar with, such as 'English' and 'Deutsch', for a more user-friendly experience and to reach a broader audience.
P.S. The position looks good on both the web and mobile.
Is there anything else you'd like me to review on this issue? cc @TenzDelek @sambhavgupta0705
@TenzDelek push a review with these changes then we can look at this
@TenzDelek push a review with these changes then we can look at this
@sambhavgupta0705 check it once. have made some adjustment to the space x due to layout shift in the nav after the long form addition
@TenzDelek I liked the design but we have a setup of using en and de so we need to change them also by replacing them with deutsch and english
cc: @anshgoyalevil
@TenzDelek I liked the design but we have a setup of using
enanddeso we need to change them also by replacing them withdeutschandenglishcc: @anshgoyalevil
You mean the params? Didn't quite get you🤔
yes the params only currently it is redirecting us to https://deploy-preview-3113--asyncapi-website.netlify.app/deutsch which is not valid
A good approach will be to change the params from de to deutsch and en to english
@TenzDelek any update?
was bit busy past few days ! will look into this today or tomorrow
yes the params only currently it is redirecting us to https://deploy-preview-3113--asyncapi-website.netlify.app/deutsch which is not valid
A good approach will be to change the params from de to deutsch and en to english
can you help me with that a little bit.. what exactly we need to perform here. little bit confuse here. is it only changing file name here or ?
cc @sambhavgupta0705
closing this as we have submitted this issue in bounty program and need a new PR for this
hey @sambhavgupta0705 need your input in this https://github.com/asyncapi/website/issues/1245#issuecomment-2543838373
closing this as we have submitted this issue in bounty program and need a new PR for this
can contributors take participation in bounty program or is it meant only for maintainers? . would love to work on this if it is for all. cc @sambhavgupta0705 , @aeworxet
closing this as we have submitted this issue in bounty program and need a new PR for this
can contributors take participation in bounty program or is it meant only for maintainers? . would love to work on this if it is for all. cc @sambhavgupta0705 , @aeworxet