website
website copied to clipboard
asyncapi
fix(link): fixing github redirecting links
Description
- Fixed the
edit-page-config.jsonfile to fix the issue - changed
pagein the href key tomarkdown
Related issue(s) Fixes #3067
Deploy Preview for asyncapi-website ready!
Built without sensitive environment variables
| Name | Link |
|---|---|
| Latest commit | e4429f8464d39734d34c9a1db44ba9f2f3de37e0 |
| Latest deploy log | https://app.netlify.com/sites/asyncapi-website/deploys/66d84df87ebe9d00081c6b37 |
| Deploy Preview | https://deploy-preview-3071--asyncapi-website.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
@akshatnema dunno why Lighthouse CI is failing even for small change is there any way to fix ?
⚡️ Lighthouse report for the changes in this PR:
| Category | Score |
|---|---|
| 🔴 Performance | 40 |
| 🟢 Accessibility | 98 |
| 🟢 Best practices | 92 |
| 🟢 SEO | 100 |
| 🔴 PWA | 33 |
Lighthouse ran on https://deploy-preview-3071--asyncapi-website.netlify.app/
Thanks for the change, @DhairyaMajmudar. Can you please dig into the issue further as I just found out some other docs edit links are broken. For example: https://www.asyncapi.com/docs/tools/generator/asyncapi-document link should have an edit link to https://github.com/asyncapi/generator/blob/master/apps/generator/docs/asyncapi-document.md but is instead https://github.com/asyncapi/generator/tree/master/docs/asyncapi-document.mdx which is wrong. There might be other such links, which you would need to find out.
Thanks for the change, @DhairyaMajmudar. Can you please dig into the issue further as I just found out some other docs edit links are broken. For example: https://www.asyncapi.com/docs/tools/generator/asyncapi-document link should have an edit link to https://github.com/asyncapi/generator/blob/master/apps/generator/docs/asyncapi-document.md but is instead https://github.com/asyncapi/generator/tree/master/docs/asyncapi-document.mdx which is wrong. There might be other such links, which you would need to find out.
Sure thing 👍🏻
@DhairyaMajmudar just check all the links and report them here after that have we can see that need to change only the config or the gh action ferentor '
Hi, @anshgoyalevil @sambhavgupta0705 I checked the links and did the needy changes in config files but the bug still exists since the links generated redirects to .mdx files instead of .md
The reason behind is their declaration in the posts.json file but since it is mentioned in .gitignore I am not able to commit the changes in that file.
EDIT: Also its a bit strange how I'm able to access the files mentioned in .gitignore
Hi, @anshgoyalevil @sambhavgupta0705 I checked the links and did the needy changes in config files but the bug still exists since the links generated redirects to
.mdxfiles instead of.mdThe reason behind is their declaration in the
posts.jsonfile but since it is mentioned in .gitignore I am not able to commit the changes in that file. EDIT: Also its a bit strange how I'm able to access the files mentioned in .gitignore
@sambhavgupta0705 just a friendly ping on this.
you also need to update the component responsible for edit link: https://github.com/asyncapi/website/blob/master/components/layout/DocsLayout.tsx#L53
@DhairyaMajmudar any updates on the PR?
I'm still unsure of this https://github.com/asyncapi/website/pull/3071#issuecomment-2222107745
@akshatnema @sambhavgupta0705 I've fixed the problem stated in https://github.com/asyncapi/website/pull/3071#issuecomment-2220436121 now links are working as expected, can you pls. review the PR.