website icon indicating copy to clipboard operation
website copied to clipboard

Enabling i18n feature for smaller screens

Open sambhavgupta0705 opened this issue 11 months ago • 29 comments

Why do we need this improvement?

Currently we have i18n feature for large screens but not for smaller screens. So we should work on enabling it for smaller screen For which first we need a design and need to know where can we place the button to switch to different languages

How will this change help?

It will enable translation to various language for smaller screens

Screenshots

No response

How could it be implemented/designed?

A design can be proposed by @Mayaleeeee on which we can work

🚧 Breaking changes

No

👀 Have you checked for similar open issues?

  • [X] I checked and didn't find a similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to work on this issue?

No, someone else can work on it.

sambhavgupta0705 avatar Feb 27 '24 11:02 sambhavgupta0705

This is not a good first issue and for this first we need a design to be implemented cc: @anshgoyalevil

sambhavgupta0705 avatar Feb 27 '24 11:02 sambhavgupta0705

Hey @sambhavgupta0705!, would like to work on this (ofc, after the design is finalized), Can i get it assigned ? Thanks!

Aryann15 avatar Feb 28 '24 04:02 Aryann15

@sambhavgupta0705 can I go for this i18 button Design in mobile devices?
WhatsApp Image 2024-02-28 at 14 41 41_0906dbfc

AbhishekCS3459 avatar Feb 28 '24 09:02 AbhishekCS3459

@Aryann15 @AbhishekCS3459 Guys you need to wait until we get a design spec for this button from @Mayaleeeee

anshgoyalevil avatar Feb 29 '24 01:02 anshgoyalevil

Hey @Mayaleeeee, can please design the spec for I18N button

its-kunal avatar Mar 05 '24 13:03 its-kunal

Hey @Mayaleeeee, can please design the spec for I18N button

I'll take a look at it.

Mayaleeeee avatar Mar 07 '24 07:03 Mayaleeeee

Hey @Mayaleeeee, any update related to this

its-kunal avatar Mar 09 '24 13:03 its-kunal

We can go for this particular icon, available in hero icons, as it's always preferred to use icons on small screens, unless the icon is very underrated and doesn't convey it's purpose.

not sure if this is a great suggestion image

akkshitgupta avatar Mar 13 '24 04:03 akkshitgupta

@akkshitgupta Can I go for it as I was working on it earlier?

AbhishekCS3459 avatar Mar 14 '24 12:03 AbhishekCS3459

@AbhishekCS3459 you can go for it once @Mayaleeeee confirms what should be done. it is still under discussion i guess ;)

akkshitgupta avatar Mar 14 '24 12:03 akkshitgupta

We can go for this particular icon, available in hero icons, as it's always preferred to use icons on small screens, unless the icon is very underrated and doesn't convey it's purpose.

not sure if this is a great suggestion image

Do you mean the language icon?

Mayaleeeee avatar Mar 20 '24 05:03 Mayaleeeee

Yes @Mayaleeeee, the language icon. may be the green mark is creating confusion. that mark was on the website

akkshitgupta avatar Mar 20 '24 05:03 akkshitgupta

Yes @Mayaleeeee, the language icon. may be the green mark is creating confusion. that mark was on the website

which green mark? I don't understand

Mayaleeeee avatar Mar 20 '24 07:03 Mayaleeeee

I misunderstood your question here, my bad 😅

Do you mean the language icon?

akkshitgupta avatar Mar 21 '24 06:03 akkshitgupta

@akkshitgupta you can make a design for the smaller screen which we can later review for smooth working

sambhavgupta0705 avatar Mar 22 '24 06:03 sambhavgupta0705

@sambhavgupta0705 can I proceed?

AbhishekCS3459 avatar Mar 22 '24 08:03 AbhishekCS3459

Ohh my bad @akkshitgupta as @AbhishekCS3459 was the first one to show interest in working on this so his PR for this issue would be considered first

sambhavgupta0705 avatar Mar 22 '24 08:03 sambhavgupta0705

@akkshitgupta so can I proceed?

AbhishekCS3459 avatar Mar 22 '24 14:03 AbhishekCS3459

@AbhishekCS3459 yes you may

sambhavgupta0705 avatar Mar 26 '24 04:03 sambhavgupta0705

Hey @sambhavgupta0705, could you please explain the flow? When the user clicks the new icon above, does it trigger a dropdown with various icons, similar to the existing setup?

AbhishekCS3459 avatar Mar 31 '24 08:03 AbhishekCS3459

similar to the existing setup?

yeahhh

sambhavgupta0705 avatar Mar 31 '24 09:03 sambhavgupta0705

any update @AbhishekCS3459 ?

sambhavgupta0705 avatar Apr 11 '24 04:04 sambhavgupta0705

@sambhavgupta0705, I am coming up with a PR today.

AbhishekCS3459 avatar Apr 11 '24 06:04 AbhishekCS3459

okay!!

sambhavgupta0705 avatar Apr 12 '24 04:04 sambhavgupta0705

@AbhishekCS3459 what's the status of the PR?

sambhavgupta0705 avatar Apr 14 '24 04:04 sambhavgupta0705

@sambhavgupta0705 can i work on it?

TenzDelek avatar Apr 17 '24 15:04 TenzDelek

@sambhavgupta0705 hello, if the previous developer is still working on it, you can close this pr

TenzDelek avatar Apr 17 '24 17:04 TenzDelek

@TenzDelek the previous contributor hasn't raised any PR from the past 2 weeks so this issue has been shifted to you so your PR will be considered for this issue

sambhavgupta0705 avatar Apr 18 '24 05:04 sambhavgupta0705