website icon indicating copy to clipboard operation
website copied to clipboard

Published 20 hours ago • verified publisher icon asyncapi

fix: redesigned the dropdown

Open sagarkori143 opened this issue 1 year ago • 17 comments

resolves: #1318

sagarkori143 avatar Feb 10 '24 18:02 sagarkori143

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
Latest commit f01a31c60a4196aa460cafcd04e9926e30367819
Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/65f5bda8e147140008460e22
Deploy Preview https://deploy-preview-2645--asyncapi-website.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Feb 10 '24 18:02 netlify[bot]

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 36
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-2645--asyncapi-website.netlify.app/

asyncapi-bot avatar Feb 10 '24 18:02 asyncapi-bot

Hey @akshatnema @sambhavgupta0705 Please have a look and give your reviews. I'll bring changes further accordingly.

sagarkori143 avatar Feb 11 '24 06:02 sagarkori143

Friendly reminder. @sambhavgupta0705

sagarkori143 avatar Feb 16 '24 04:02 sagarkori143

hey @Mayaleeeee This PR is related to design. Please have a look and give suggestions.

sagarkori143 avatar Feb 22 '24 16:02 sagarkori143

@Mayaleeeee PTAL

sambhavgupta0705 avatar Feb 27 '24 11:02 sambhavgupta0705

Hey @akshatnema . I have pushed the requested changes. PTAL.

sagarkori143 avatar Mar 01 '24 17:03 sagarkori143

Okay @sambhavgupta0705 Discarding them right now!!

sagarkori143 avatar Mar 04 '24 17:03 sagarkori143

@sagarkori143 please remove changes of adopters.json

Done @sambhavgupta0705 👍

sagarkori143 avatar Mar 04 '24 17:03 sagarkori143

https://github.com/asyncapi/website/assets/81870866/a0fdf6c3-f246-4c1e-9935-34d3d9783bf6

@sagarkori143 while selecting the drop-down options on mobile it is giving a bad experience to users Can you please look after this

sambhavgupta0705 avatar Mar 05 '24 04:03 sambhavgupta0705

@sagarkori143 any update

sambhavgupta0705 avatar Mar 11 '24 06:03 sambhavgupta0705

Hey @sambhavgupta0705 . Yes I'm trying to find out the reason for that unwanted user experience.

sagarkori143 avatar Mar 12 '24 15:03 sagarkori143

Hey @sambhavgupta0705 . Yes I'm trying to find out the reason for that unwanted user experience.

Great job, @sagarkori143! Can you share the link for the dropdown menu?

Mayaleeeee avatar Mar 20 '24 07:03 Mayaleeeee

Hey @sambhavgupta0705 . Yes I'm trying to find out the reason for that unwanted user experience.

Great job, @sagarkori143! Can you share the link for the dropdown menu?

Hey @Mayaleeeee I didn't understand which link you are referring to. Please clarify.

sagarkori143 avatar Mar 21 '24 06:03 sagarkori143

@Mayaleeeee here is the url https://www.asyncapi.com/tools

sambhavgupta0705 avatar Mar 21 '24 16:03 sambhavgupta0705

I have gone through all the components of the filters section and checked them for onclick event listeners. Everything seems okay to me and I am not able to find the reason for that unwanted onclick behavior. I need some assistance in this. @sambhavgupta0705

sagarkori143 avatar Apr 01 '24 04:04 sagarkori143

@akshatnema can you please look after this one as you have a better knowledge of tools section

sambhavgupta0705 avatar Apr 01 '24 17:04 sambhavgupta0705