website icon indicating copy to clipboard operation
website copied to clipboard

feat: add subscribe form to meetings and tsc page

Open fmvilas opened this issue 3 years ago • 3 comments

It adds a subscription form to the /community/meetings page. I've configured (still on it while opening this PR) Mailchimp to tag users as "meetings-email" so we know exactly which of them should be receiving the weekly meetings email.

Not sure there's a related issue. It's been a long-awaited feature by @derberg (along with the TSC members voting email, which will come next).

EDIT:

It also eliminates the need to pass a formName param to the NewsletterSubscribe component. We'll always use the same because Zapier/Netlify integration is done by form. This means we need to create a Zap per form and Zapier charges per Zap. Since we're not interested in which form was used, I'm always using the same form name, and the routing will happen based on the type field (e.g., jobs, meetings-email, etc.). If no type is provided, it will just be understood as you're subscribing to the newsletter, as usual.

EDIT 2:

I'm also adding the TSC voting form on the /community/tsc page, so people can get notified when someone requests the TSC to vote.

Check after merge

  • [ ] List of interests show TSC voting email and Meetings email. See https://github.com/asyncapi/website/pull/1026#pullrequestreview-1145475062 for context.

fmvilas avatar Oct 17 '22 15:10 fmvilas

Deploy Preview for asyncapi-website ready!

Name Link
Latest commit 59b82d44e80d9ea07c92a37dc4f854ddcdc33d20
Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/63580f160039260008011553
Deploy Preview https://deploy-preview-1026--asyncapi-website.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Oct 17 '22 15:10 netlify[bot]

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 43
🟠 Accessibility 88
🟠 Best practices 83
🟢 SEO 90
🔴 PWA 30

Lighthouse ran on https://deploy-preview-1026--asyncapi-website.netlify.app/

github-actions[bot] avatar Oct 17 '22 15:10 github-actions[bot]

So as I understand, when we send email about meetings it is still going to be:

            recipients: {
                list_id: '6e3e437abe',
                segments_opts: {
                    saved_segment_id: 'meetings-email'
                }
            }

now, in case of TSC, we should send to:

            recipients: {
                list_id: '6e3e437abe',
                segments_opts: {
                    saved_segment_id: 'tsc-voting-email'
                }
            }

so still the same list, just different segment. Right?

Yes, if I understood Mailchimp API correctly, that's the case.

Then, when I finally get a link, in update I see only but I see meetings and tsc too, right?

I'm not quite sure but that's something we can test after it's merged. If it doesn't work, I'd just have to tweak it on Mailchimp so no problem.

Just to confirm, you wanna also extend https://github.com/asyncapi/community/blob/master/.github/workflows/notify-tsc-members-mention.yml to send email to Mailchimp, or you leave it to me?

I'll leave it up to you. Maybe someone else can help? @KhudaDad414, you're familiar with Github Actions, maybe you can help?


All feedback is addressed now @derberg. Please review it again.

fmvilas avatar Oct 20 '22 04:10 fmvilas

@fmvilas regarding how it looks like in Mailchimp I think it can only be done in the Mailchimp, the "update of preferences" this PR has nothing to do with it.

you can check with https://gmail.us12.list-manage.com/profile/send-email

derberg avatar Oct 25 '22 14:10 derberg

@fmvilas can you also check something in Mailchimp. Not sure how you, but I did not receive an email this week (Monday) about the meetings from this week but in CI I can see that campaign was created in mailchimp

derberg avatar Oct 25 '22 14:10 derberg

@fmvilas regarding how it looks like in Mailchimp I think it can only be done in the Mailchimp, the "update of preferences" this PR has nothing to do with it.

you can check with https://gmail.us12.list-manage.com/profile/send-email

I don't get what you're talking about 🤔 Also, the link doesn't work for me.

@fmvilas can you also check something in Mailchimp. Not sure how you, but I did not receive an email this week (Monday) about the meetings from this week but in CI I can see that campaign was created in mailchimp

I did receive the email 🤔 I wonder what failed.

fmvilas avatar Oct 25 '22 16:10 fmvilas

/rtm

fmvilas avatar Oct 25 '22 16:10 fmvilas

Oh yeah, I'm editing a Markdown file so I need approval from @alequetzalli :)

fmvilas avatar Oct 25 '22 16:10 fmvilas