website
website copied to clipboard
docs: new streetlights tutorial on how to "generate code"
Description This is the second part of the streetlights tutorial which describes how to "generate code" from the specification document.
Related issue(s) Fixes #1010
Deploy Preview for asyncapi-website ready!
Built without sensitive environment variables
Name | Link |
---|---|
Latest commit | 43f56b9c117b74d5f1bb444885ee2b5dde02f626 |
Latest deploy log | https://app.netlify.com/sites/asyncapi-website/deploys/63f936e2aee0820008f1d80e |
Deploy Preview | https://deploy-preview-1025--asyncapi-website.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Hello @alequetzalli and @derberg , I would love your feedbacks. Thank you!
β‘οΈ Lighthouse report for the changes in this PR:
Category | Score |
---|---|
π Performance | 58 |
π Accessibility | 88 |
π’ Best practices | 100 |
π’ SEO | 100 |
π΄ PWA | 30 |
Lighthouse ran on https://deploy-preview-1025--asyncapi-website.netlify.app/
@derberg Thank you for all the suggested changes. I just implemented them. Kindly have a look.
pingy pongo @derberg π¬π¬π¬
Hey @Annysah, please review and make sure you resolve all comments in this PR when you address the feedback. It is confusing as it currently stands. π
Hey @Annysah, please review and make sure you resolve all comments in this PR when you address the feedback. It is confusing as it currently stands. π
Noted Alejandra!
Hi @alequetzalli & @derberg, I just updated the requested changes, kindly help review.
@alequetzalli & @derberg, all done! Kindly help review. Thank you!
so I need to add the new CLI installation info block here @Annysah, it's just that I can't do that until my CLI PR https://github.com/asyncapi/website/pull/1139 is merged... stay tuned and I will add it asap πβπ½
so I need to add the new CLI installation info block here @Annysah, it's just that I can't do that until my CLI PR #1139 is merged... stay tuned and I will add it asap πβπ½
alrighty! β€οΈ
Added some comments. Also, I've an advice, if you can add some indentations here. Like the content inside that header should have an indentation of a tab in the left, so that it looks like the content resides in the header section.
sorry, what? π I donβt understand the indentations feedback at all π¬ @akshatnema
Also, the CLI command here is not rendering properly, as per the backtick used in the code.
oh nooooo ... groans* ... arrghhhh
better open a PR for the fragments file to see how to fix that >_>
opened a bug issue to look into it @akshatnema βπ½
https://github.com/asyncapi/website/issues/1308
also there are errors with formatting, look at https://deploy-preview-1025--asyncapi-website.netlify.app/docs/tutorials/generate-code you see, the code snippet is "disconnected" from the number
oh yikes, I missed that! fixing O_O
ooookay so @derberg my findings...
- the formatting differences you found are because some code blocks used
<CodeBlock language="bash">
(those are the ones that you felt "looked right" and others used ``` (those are the ones that you felt had formatting spacing issues) - I tried to fix it and have them all be
<CodeBlock language="bash">
, but now I am getting deployment errors I was unable to figure out on my own and netlify won't generate the latest preview - yay -__- what do I do now?
yo @derberg, so I accepted your commit suggestion fix but it didn't fix the problem :( cry
https://deploy-preview-1025--asyncapi-website.netlify.app/docs/tutorials/generate-code

/rtm