website icon indicating copy to clipboard operation
website copied to clipboard

docs: new streetlights tutorial on how to "create asyncapi documents"

Open Annysah opened this issue 2 years ago • 4 comments

Description

  • This is the first part on the streetlights tutorial which describes how to "create asyncapi documents"

Related issue(s) Fixes #850

Annysah avatar Oct 14 '22 14:10 Annysah

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
Latest commit cda02dd40c39d92aa3c9d361e74ab6b0e6e73b4c
Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/63f91e032ec14300083834f4
Deploy Preview https://deploy-preview-1023--asyncapi-website.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Oct 14 '22 14:10 netlify[bot]

Hello @alequetzalli & @derberg , I would love your feedbacks Thank you!

Annysah avatar Oct 14 '22 14:10 Annysah

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 51
🟠 Accessibility 88
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-1023--asyncapi-website.netlify.app/

github-actions[bot] avatar Oct 14 '22 14:10 github-actions[bot]

Thanks @derberg! I just sent in my update, kindly have a look.

Annysah avatar Oct 22 '22 03:10 Annysah

Hi @alequetzalli & @derberg, I've implemented the changes, kindly help review. Thank you!

Annysah avatar Nov 11 '22 01:11 Annysah

I just left one comment and looks like this one is ready.

What are the plans for merging these, are you waiting for all tutorials to be ready or?

derberg avatar Nov 16 '22 12:11 derberg

What are the plans for merging these, are you waiting for all tutorials to be ready or?

Yes @derberg all 4 new GSoD tutorials must be merged together. We decided this months ago because of the prev/next buttons each one has.

quetzalliwrites avatar Dec 14 '22 04:12 quetzalliwrites

We decided this months ago because of the prev/next buttons each one has.

I already know, my comment is month old 😼

derberg avatar Dec 15 '22 12:12 derberg

We decided this months ago because of the prev/next buttons each one has.

I already know, my comment is month old 😼

BAHAHAHA oops my bad then 🙊 😂 @derberg

quetzalliwrites avatar Dec 16 '22 01:12 quetzalliwrites

it has been a while, sorry but I need to clarify

in case of tutorials, didn't we agree that there will always be a CLI command (maybe also studio instruction) that will instruct how to perform tutorial steps? so in the end you can just do asyncapi new SOMETHING and you get the same file generated immediately? to assure tutorials are based on the same example?

something like https://github.com/asyncapi/website/pull/1061/files#diff-8e9be9eabe193de3ae63ce37ae40ca0ab76e4567ed323f605572fa788f48da97R17-R27 that you can see here https://deploy-preview-1061--asyncapi-website.netlify.app/docs/tutorials/message-validation#background-context

derberg avatar Jan 31 '23 17:01 derberg

it has been a while, sorry but I need to clarify

in case of tutorials, didn't we agree that there will always be a CLI command (maybe also studio instruction) that will instruct how to perform tutorial steps? so in the end you can just do asyncapi new SOMETHING and you get the same file generated immediately? to assure tutorials are based on the same example?

something like https://github.com/asyncapi/website/pull/1061/files#diff-8e9be9eabe193de3ae63ce37ae40ca0ab76e4567ed323f605572fa788f48da97R17-R27 that you can see here https://deploy-preview-1061--asyncapi-website.netlify.app/docs/tutorials/message-validation#background-context

added, we're ready for review again @derberg

quetzalliwrites avatar Feb 08 '23 04:02 quetzalliwrites

You wrote "this tutorial is about creating asyncapi document, no generation should be mentioned", but then you proceed to add a commit with the word generate 😜 ... nicely going there @derberg ... 😂

Screen Shot 2023-02-08 at 6 43 40 PM

Nice catch tho so thank you... and I fixed it for real 😄✌🏽

quetzalliwrites avatar Feb 09 '23 02:02 quetzalliwrites

/rtm

quetzalliwrites avatar Feb 24 '23 22:02 quetzalliwrites