website icon indicating copy to clipboard operation
website copied to clipboard

docs: new guide for message validation

Open starlightknown opened this issue 3 years ago β€’ 6 comments

Description

  • New guide for validation of AsyncAPI message validation

Related issue(s)

Fixes #994

starlightknown avatar Oct 06 '22 04:10 starlightknown

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
Latest commit 5ba87929547f76a892b7bca80bb9497a42eace7b
Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/63f939152c7bf900084ff590
Deploy Preview https://deploy-preview-1005--asyncapi-website.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Oct 06 '22 04:10 netlify[bot]

  • remove git, mention npm instead of node
  • validator and gateway getting started in prerequisites, link installation
  • two different ways, link repos
  • additional resources, studio and blog post asyncapi
  • asyncapi schema validator
  • header 1 scenarios, header 2 scenarios, header 3 examples
  • validatemessage id example, shorten example headings

starlightknown avatar Oct 06 '22 15:10 starlightknown

@akshatnema Heyo, can you help Karuna here? She is trying to figure out why her builds are failing and not generating the Netlify preview πŸ˜„βœŒπŸ½

quetzalliwrites avatar Oct 06 '22 16:10 quetzalliwrites

⚑️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 56
🟠 Accessibility 88
🟒 Best practices 100
🟒 SEO 100
πŸ”΄ PWA 30

Lighthouse ran on https://deploy-preview-1005--asyncapi-website.netlify.app/

github-actions[bot] avatar Oct 06 '22 18:10 github-actions[bot]

Thanks a lot! @akshatnema I'd still be searching for { because that's what logs showed

starlightknown avatar Oct 06 '22 18:10 starlightknown

Hey @derberg, this is ready for technical review! I made a draft update, so I hope I didn't add technical mistakes πŸ˜‚

quetzalliwrites avatar Oct 12 '22 02:10 quetzalliwrites

Hi @starlightknown, is this PR ready for review again? i wasn't sure so I wanted to double check with you πŸ˜„βœŒπŸ½

quetzalliwrites avatar Oct 26 '22 02:10 quetzalliwrites

Hi @starlightknown, is this PR ready for review again? i wasn't sure so I wanted to double check with you smile✌🏽

yep @alequetzalli now it's ready

starlightknown avatar Oct 26 '22 13:10 starlightknown

Hey @starlightknown, please add the Prev and UpNext buttons on this Doc page and change the routes of buttons in adjacent pages accordingly.

Hey, so this is the last tutorial according to the order Alejandra mentioned. Create AsyncAPI document Validate AsyncAPI document Generate Code Validate Events/Messages

this is validate events/messages. I'm not sure what should come after this

starlightknown avatar Nov 06 '22 13:11 starlightknown

this is validate events/messages. I'm not sure what should come after this

So, are we going to merge this PR first or will wait for others to merge first?

akshatnema avatar Nov 06 '22 17:11 akshatnema

this is validate events/messages. I'm not sure what should come after this

So, are we going to merge this PR first or will wait for others to merge first?

This is the last PR in order so ig we wait for other three to get merged before

starlightknown avatar Nov 06 '22 18:11 starlightknown

added buttons @alequetzalli

starlightknown avatar Nov 08 '22 07:11 starlightknown

Hey @starlightknown, please add the Prev and UpNext buttons on this Doc page and change the routes of buttons in adjacent pages accordingly.

Hey, so this is the last tutorial according to the order Alejandra mentioned. Create AsyncAPI document Validate AsyncAPI document Generate Code Validate Events/Messages

this is validate events/messages. I'm not sure what should come after this

@starlightknown this is NOT a tutorial like you wrote above, this is a GUIDE. 😜 We only have your guide and the one Anisat wrote. We will place this guide as the 2nd one in the guide content bucket.

The next button should point to our next content bucket, Reference and its /Overview page.

quetzalliwrites avatar Nov 08 '22 23:11 quetzalliwrites

Does this need another technical review round, @derberg? 🧐

sorry if I missed something, just trying to keep up too πŸ˜‚

quetzalliwrites avatar Nov 16 '22 01:11 quetzalliwrites

@alequetzalli tbh I don't know. Usually, people write comments that another review round is expected. Although I prefer if the arrows icon is clicked πŸ‘‡πŸΌ GitHub do not send notification that something new was pushed to the repo after last review 🀷🏼

Screenshot 2022-11-22 at 12 59 15

@starlightknown is this ready for another review?

derberg avatar Nov 22 '22 12:11 derberg

@alequetzalli tbh I don't know. Usually, people write comments that another review round is expected. Although I prefer if the arrows icon is clicked πŸ‘‡πŸΌ GitHub do not send notification that something new was pushed to the repo after last review 🀷🏼

Screenshot 2022-11-22 at 12 59 15

@starlightknown is this ready for another review?

yep it's good for another review

starlightknown avatar Nov 22 '22 12:11 starlightknown

Where are we at with this guide, @starlightknown? Are you done addressing Lukasz feedback or..? πŸ˜„βœŒπŸ½

quetzalliwrites avatar Dec 06 '22 01:12 quetzalliwrites

Where are we at with this guide, @starlightknown? Are you done addressing Lukasz feedback or..? smile✌🏽

I still need to fix few things, I'll be done by today

starlightknown avatar Dec 06 '22 02:12 starlightknown

done, this is up for one more review

starlightknown avatar Dec 06 '22 14:12 starlightknown

@alequetzalli all done

starlightknown avatar Jan 20 '23 17:01 starlightknown

all done, removed docs buttons for all of my PRs

starlightknown avatar Jan 22 '23 09:01 starlightknown

@alequetzalli I left some final comments yesterday, please have a look

derberg avatar Feb 08 '23 08:02 derberg

/rtm

quetzalliwrites avatar Feb 24 '23 22:02 quetzalliwrites