website icon indicating copy to clipboard operation
website copied to clipboard

docs: new guide for validation of AsyncAPI files

Open Annysah opened this issue 2 years ago • 4 comments

Description

  • New guide for validation of AsyncAPI document.

Related issue(s) Fixes #994

Annysah avatar Oct 05 '22 04:10 Annysah

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
Latest commit 89c36e0d1d6aa1a0b8fd910180e6cb4a06dc80f8
Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/63f939e4d5b80a0008cde688
Deploy Preview https://deploy-preview-1002--asyncapi-website.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Oct 05 '22 04:10 netlify[bot]

Hello @alequetzalli and @derberg, I would love your feedbacks on this. Thank you!

Annysah avatar Oct 05 '22 04:10 Annysah

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 63
🟠 Accessibility 88
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-1002--asyncapi-website.netlify.app/

github-actions[bot] avatar Oct 05 '22 04:10 github-actions[bot]

@fmvilas @smoya @derberg This NEW guide is now ready for technical review. ✨

quetzalliwrites avatar Oct 07 '22 00:10 quetzalliwrites

Hey @Annysah, how's the next draft coming along? does Lukasz's feedback make sense to you? 😄

quetzalliwrites avatar Oct 26 '22 02:10 quetzalliwrites

Hey @Annysah, how's the next draft coming along? does Lukasz's feedback make sense to you? 😄

Haha 😄 yes it does.

Annysah avatar Nov 06 '22 23:11 Annysah

Dear @alequetzalli & @derberg, I would love your feedbacks on the update. Thank you!

Annysah avatar Nov 07 '22 00:11 Annysah

Hey @Annysah, you need to RESOLVE each comment you address. I see Lukasz already mentioned this above, but you still have many unresolved comments, making it seem you have not yet addressed the feedback. Please go through this PR carefully and make sure you resolve all comments.

quetzalliwrites avatar Nov 09 '22 00:11 quetzalliwrites

left my review ✌🏽😄

Thanks @alequetzalli & @derberg for the feedbacks.

left my review ✌🏽😄

Thanks @alequetzalli and @derberg

Annysah avatar Nov 09 '22 01:11 Annysah

Hello @alequetzalli & @derberg , I've implemented the requested changes, kindly help review. Thank you!

Annysah avatar Nov 13 '22 14:11 Annysah

@alequetzalli & @derberg, all done!

Annysah avatar Nov 18 '22 03:11 Annysah

Hi @derberg & @alequetzalli, I have updated the changes. Kindly review. Thank you!

Annysah avatar Nov 25 '22 04:11 Annysah

technically all good from my side

@alequetzalli I guess you need to have a final look.

yaay!!

Annysah avatar Dec 13 '22 03:12 Annysah

Approved, but we can't merge yet because the prev/next buttons point to message validation guide PR https://github.com/asyncapi/website/pull/1005 which @starlightknown is still working on 😄

@derberg

quetzalliwrites avatar Dec 14 '22 03:12 quetzalliwrites

/rtm

quetzalliwrites avatar Feb 24 '23 22:02 quetzalliwrites