studio icon indicating copy to clipboard operation
studio copied to clipboard

feat: added tooltips for navigation bar (#193)

Open boyney123 opened this issue 3 years ago • 6 comments

Description

Following #193, I added some tooltips to the navigation bar.

Let me know what you think @mcturco @magicmatatjahu

boyney123 avatar Dec 16 '21 10:12 boyney123

✔️ Deploy Preview for modest-rosalind-098b67 ready!

🔨 Explore the source changes: abab3c0c6e594e20b642da7735f78af323eead82

🔍 Inspect the deploy log: https://app.netlify.com/sites/modest-rosalind-098b67/deploys/61bb1808fc8012000753160a

😎 Browse the preview: https://deploy-preview-215--modest-rosalind-098b67.netlify.app/

netlify[bot] avatar Dec 16 '21 10:12 netlify[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Dec 16 '21 10:12 sonarqubecloud[bot]

Thanks @boyney123 for adding this!! 🎉 However, I think if we made the background of the labels fully opaque it would look a lot cleaner. I think it might be a little distracting to see things peeking through behind the labels as the text size is already rather small. What do you think?

It should be integrated not with icon, but with whole nav item :)

I agree with @magicmatatjahu here completely!! Better accessibility 😎

mcturco avatar Dec 16 '21 15:12 mcturco

@boyney123 @magicmatatjahu

Hey guys! Was cleaning out my inbox and realized that this PR has yet to be merged. I think this is still a great feature that we should consider revisiting and merging. I think all we should do is make the tool tips fully opaque instead of transparent and integrate them with the entire button and not just the icon. Then we should definitely ship it! What do you guys think?

mcturco avatar Mar 08 '22 15:03 mcturco

@mcturco Yeah, we should handle that PR as you wrote. If @boyney123 you don't have time I can handle that, no problem :)

magicmatatjahu avatar Mar 08 '22 16:03 magicmatatjahu

This pull request has been automatically marked as stale because it has not had recent activity :sleeping:

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience :heart:

github-actions[bot] avatar Jul 07 '22 00:07 github-actions[bot]

This pull request has been automatically marked as stale because it has not had recent activity :sleeping:

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience :heart:

github-actions[bot] avatar Nov 05 '22 00:11 github-actions[bot]

Tooltips added in the https://github.com/asyncapi/studio/pull/434 PR

@boyney123 I hope that you don't have a problem that I'm closing this PR :)

magicmatatjahu avatar Nov 21 '22 17:11 magicmatatjahu